Repository navigation
Conversation
Since DSI 6G v1.2.0 the host sets DSI_TRIG_CTRL.BLOCK_DMA_WITHIN_FRAME, which holds a command DMA until the video stream is in blanking. dsi_wait4video_eng_busy() still waits for VIDEO_DONE and then sleeps 2-4 ms before every command. The sleep is longer than the vertical blanking of many panels. A Samsung S6E88A0 panel (540x960, 24 blanking lines) has 0.41 ms of it. The command then waits in hardware for the next blanking, so every command costs about two frames. Skip the software wait when the hardware blocks the DMA itself. On MSM8916 a brightness update of six commands to that panel now takes about 36 ms instead of about 275 ms. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2–4 ms software wait before each command in video mode is longer than the vertical blanking of many panels, so each command cost about two frames. The hardware already holds the DMA until blanking on DSI 6G v1.2+.
Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. A brightness update to the S6E88A0 panel takes about 36 ms instead of about 275 ms.
Per
CONTRIBUTING.mdthis touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.