Repository navigation
Conversation
msm_dsi_host_xfer_prepare() sets the link clock rates before each command transfer. msm_dsi_host_power_on() has already set them, and the link clocks stay enabled until power off. Transfers are refused while the host is powered off. When the PLL can't produce the requested byte clock exactly, the clock core doesn't treat the call as a no-op. It reprograms the DSI PLL for every command, while the video mode stream is running. On a Samsung S6E88A0 panel (MSM8916) the byte clock is 57739160 Hz for a 57741000 Hz request. Every brightness update made the picture lose sync for a moment. Only enable the link clocks in msm_dsi_host_xfer_prepare(). Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every DSI command reprogrammed the DSI PLL while video was running, because the PLL cannot hit the requested byte clock exactly. On the S6E88A0 panel every brightness change made the picture lose sync for a moment.
Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. No more glitches on brightness changes.
Per
CONTRIBUTING.mdthis touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.