Skip to content

drm/msm/dsi: Don't set the link clock rates for every command - #455

Closed
vlw wants to merge 1 commit into
msm8916-mainline:wip/msm8916/7.0from
vlw:msm-dsi-link-clk-rate
Closed

vlw wants to merge 1 commit into
msm8916-mainline:wip/msm8916/7.0from
vlw:msm-dsi-link-clk-rate

Conversation

@vlw

@vlw vlw commented Nov 15, 2026

Copy link
Copy Markdown

Every DSI command reprogrammed the DSI PLL while video was running, because the PLL cannot hit the requested byte clock exactly. On the S6E88A0 panel every brightness change made the picture lose sync for a moment.

Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. No more glitches on brightness changes.

Per CONTRIBUTING.md this touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.

msm_dsi_host_xfer_prepare() sets the link clock rates before each
command transfer. msm_dsi_host_power_on() has already set them, and
the link clocks stay enabled until power off. Transfers are refused
while the host is powered off.

When the PLL can't produce the requested byte clock exactly, the
clock core doesn't treat the call as a no-op. It reprograms the DSI
PLL for every command, while the video mode stream is running. On a
Samsung S6E88A0 panel (MSM8916) the byte clock is 57739160 Hz for a
57741000 Hz request. Every brightness update made the picture lose
sync for a moment.

Only enable the link clocks in msm_dsi_host_xfer_prepare().

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
@vlw vlw closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant