Repository navigation
fix: make interrupted indexing retryable and reset cancelled dialogs - #212
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the remaining Quiz/Anki Cancel reset paths and makes interrupted indexing visible and retryable after restarting the desktop app.
Why?
Cancel buttons bypassed the dialogs' reset handlers, leaving temporary question/card counts, difficulty, and prompts behind when reopening.
The ingestion queue is in memory. Exiting during indexing left persisted documents in
pendingorprocessing, displaying an indexing spinner indefinitely without a Retry action.What changed?
handleOpenChange(false)reset paths.pending/processingdocuments asfailed.This is deliberately not a durable queue or automatic resume implementation. Existing retry prerequisites still apply: a source needs saved content or a local copy. A URL interrupted before either is saved may need to be imported again.
How was this tested?
npm test: 493/493 tests passed.npm run build: passed, including the fullnpm run typecheckgate.npm run build:unpack: passed on Linux x64.npm run smoke:packaged: passed, including 29 packaged-app checks.no-explicit-anywarnings.git diff --check: passed.Checklist
npm run typecheckpasses.npm run buildpasses.Desktop / build changes
npm run build:unpackpasses.npm run smoke:packagedpasses.