Skip to content

fix: surface generation errors and guide initial model setup - #211

Merged
mrsibe merged 1 commit into
mainfrom
fix/generation-feedback-onboarding
Oct 1, 2026
Merged

mrsibe merged 1 commit into
mainfrom
fix/generation-feedback-onboarding

Conversation

@mrsibe

@mrsibe mrsibe commented Oct 1, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Surfaces actionable generation errors and expands first-run onboarding with embedding and chat model setup.

Why?

Users previously saw a generic failure or no feedback when generation failed, while the actual reason was only logged to the console. New users also had no model setup steps in onboarding, despite embedding and chat models serving different purposes.

What changed?

  • Display specific errors for Anki card, quiz, and mind map generation, including rejected background IPC calls.
  • Display errors when sending questions, retrying answers, or continuing answers; preserve existing inline feedback for streaming failures.
  • Add embedding setup and optional chat setup after language selection, reusing the existing model configuration UI.
  • Allow users to defer model setup; persist configurations when continuing and discard skipped connection edits.
  • Display onboarding and embedding download errors in the UI.
  • Add English and Simplified Chinese copy and regression guards for feedback and onboarding entry points.

How was this tested?

  • npm test: all 490 tests passed.
  • npm run build: passed, including the full npm run typecheck gate.
  • Targeted ESLint checks: no errors; one existing Hook dependency warning in NotePanel.tsx.
  • git diff --check: passed.
  • Electron interaction, real model downloads, and end-to-end generation have not been manually verified.

Screenshots / recordings

Not captured in this environment. The onboarding UI changes still need visual and desktop interaction verification.

Checklist

  • I have reviewed my own changes.
  • npm run typecheck passes.
  • npm run build passes.
  • I have tested the affected user workflow.
  • I have not included unrelated changes.
  • I have updated documentation when necessary. (No separate documentation changes were needed; onboarding guidance is included in the UI.)

Desktop / build changes

  • Not applicable
  • npm run build:unpack passes.
  • npm run smoke:packaged passes.

@github-actions github-actions Bot added the bug Something isn't working label Oct 1, 2026
@mrsibe
mrsibe merged commit 7a1fc4c into main Oct 1, 2026
4 checks passed
@mrsibe
mrsibe deleted the fix/generation-feedback-onboarding branch October 1, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant