Repository navigation
fix: surface generation errors and guide initial model setup - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Surfaces actionable generation errors and expands first-run onboarding with embedding and chat model setup.
Why?
Users previously saw a generic failure or no feedback when generation failed, while the actual reason was only logged to the console. New users also had no model setup steps in onboarding, despite embedding and chat models serving different purposes.
What changed?
How was this tested?
npm test: all 490 tests passed.npm run build: passed, including the fullnpm run typecheckgate.NotePanel.tsx.git diff --check: passed.Screenshots / recordings
Not captured in this environment. The onboarding UI changes still need visual and desktop interaction verification.
Checklist
npm run typecheckpasses.npm run buildpasses.Desktop / build changes
npm run build:unpackpasses.npm run smoke:packagedpasses.