fix: log warning on _extract_summaries exception instead of silent failure#6
Merged
Merged
Conversation
…_summaries Previously, any parse failure returned "" with no indication of what went wrong. Now logs a WARNING with the exception message so failures are visible in logs without changing the fallback behavior. Adds 3 unit tests for _extract_summaries: invalid JSON logs warning, nested summaries extracted correctly, empty nodes returns "". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_extract_summarieswas catching all exceptions and returning""with no log output. Any parse failure was invisible — the user would get a context-less LLM response with no indication of what went wrong.Fix: log a
WARNINGwith the exception message before returning"". Behavior is unchanged, failures are now visible.Tests added (56 total, up from 53)
3 new unit tests for
_extract_summaries:""""Test plan
🤖 Generated with Claude Code