perf: cache document structures to avoid repeated disk reads#4
Merged
Conversation
get_structure() now caches results in _structure_cache on first call. Cache is invalidated when a document is re-indexed. Without this, every chat request reads and parses the PageIndex JSON for all indexed documents on every call — O(n) disk I/O per request. Also adds test_indexer.py (8 tests) covering cache hits, cache misses, independent caching per doc, cache invalidation, and dedup logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each chat request was reading and parsing the PageIndex JSON structure for every indexed document on every call — O(n) disk I/O per request.
Fix:
get_structure()now caches results in_structure_cacheon first call. Cache is invalidated when a document is re-indexed.Tests added (46 total, up from 38)
New
test_indexer.py(8 tests):Test plan
🤖 Generated with Claude Code