Fixes for CRAN - #252
Merged
Merged
Conversation
richfitz
marked this pull request as ready for review
January 19, 2026 22:31
weshinsley
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the build on CRAN (failing here) as vctrs has changed behaviour to fix a bug (reported in #250). Unfortunately, despite the nice warning that the breaking change was coming via GitHub, none of us have noticed and no email to the mantainer address was sent, so the first I knew about this was a
messagefrom CRAN, but thankfully this time I was not on holiday.I suspect the offending test was put in by Paul to make sure that we could rely on the package not doing something odd in a corner case but I must admit that I've not dug back into this, nor can I remember the specifics (just that the bookkeeping was somewhat tedious).
See a failing build on be68768 with the same message as CRAN - this was just with a version bump, this is fixed in
ed3f1eb which simply removes the offending test.
I've uploaded to win builder to do a pre-flight test on r-devel and` that's come back OK: https://win-builder.r-project.org/L4bIUTDv08Dn/
Can you look at this please @weshinsley or @EmmaLRussell (or anyone else interested) and I'll get the package sent back up before it meets its demise
Fixes #250
Also fixes the failing r-universe build, which now uses the updated version of
vctrs