Repository navigation
Upgrade React Router to patched v7 and cover existing app routes - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web/package.json:28retained React Router 6.30.4 after its Dependabot PR was closed.npm auditon main reports two moderate advisories throughreact-router/react-router-dom(GHSA-wrjc-x8rr-h8h6 and GHSA-337j-9hxr-rhxg); the patched range starts at 7.18.0.Upgrade to 7.18.4, refresh the lockfile, and add ten route regression cases covering reserved pages, reset/verification tokens, local topics, external hosts with custom ports and notification query parameters. The app uses declarative BrowserRouter routes, with no data loaders, SSR hydration or relative splats; this fixes dependency exposure without claiming a demonstrated SSR exploit in this app.
Validation: npm ci, ESLint, production build and all 111 web tests pass; npm audit reports zero vulnerabilities. Requires Node >=20 and React >=18 (the existing CI uses Node 24). This PR targets main and is independent of #46.