Repository navigation
Conversation
tests/test_apkdiff.py and tests/test_release_workflow.py were added with no CI job, so their regression value was zero by default. Run unittest discover when tests/ exists; keep the job green on branches without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published as a draft for owner review.
Problem
tests/test_apkdiff.py(AMB-008) andtests/test_release_workflow.py(AMB-010) ship with the fix branches but no CI job executes them — their regression value was zero by default, and the AMB-010 PR body already had to disclose "the test is local and is not automatically wired into existing CI."Fix
New
Python regressionsworkflow:python3 -m unittest discover -s tests -vwhenever atests/directory exists, no-op (green) on branches without one. Triggered onpull_request→ master andpush→ master, matchingcheck-offline-permissions.yml's shape;contents: readonly; 5-minute timeout.Once AMB-008 and AMB-010 merge to master, every later PR — including their own follow-ups — runs both suites automatically.
Validation
Self-evident from the YAML; the suites themselves pass locally (see
apkdiff-patched.log/release-tag-patched.login the local evidence package) and will run on this branch's CI as a trivial no-op untiltests/lands.