Make gcc diagnostics color output work the same as for rustc#2758
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
==========================================
+ Coverage 74.18% 74.19% +0.01%
==========================================
Files 71 71
Lines 40491 40505 +14
==========================================
+ Hits 30037 30052 +15
+ Misses 10454 10453 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jwidauer
force-pushed
the
fix-gcc-color-output
branch
from
13a6c08 to
105a89b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
sccachewith gcc using the-fdiagnostics-color=autoflag, there is currently no color output being shown.This is due to gcc not outputting colors, when standard error is not a terminal, which is the case when using sccache.
This PR addresses this behavior, by making sccache behave similarly for gcc as for rustc. When the
-fdiagnostics-colorflag is specified, it will remove this flag from the arguments and add it back as-fdiagnostics-color=always, if thecolor_modeis set toOnorAuto.Please let me know if there is anything I should change or might not have considered!