fall back locally on server connection/startup failures#2756
Open
ken-matsui wants to merge 1 commit into
Open
Conversation
README.md states:
To have sccache instead gracefully failover to the local compiler
without stopping, set the environment variable
`SCCACHE_IGNORE_SERVER_IO_ERROR=1`.
This patch extends this behavior to failures that happen during
connect_or_start_server.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 74.18% 73.32% -0.86%
==========================================
Files 71 71
Lines 40491 40554 +63
==========================================
- Hits 30037 29736 -301
- Misses 10454 10818 +364 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Hi @sylvestre, the CI error looks unrelated to this patch. Could you please rerun it and review this? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md states:
This patch extends this behavior to failures that happen during connect_or_start_server.