Skip to content

Commit 75b321b

Browse files
committed
Isolate the viewer integration tests
To avoid being able to introduce dependencies between tests this commit makes sure that we close the document between tests so that we can't accidentally rely on state set by a previous test.
1 parent 965949c commit 75b321b

1 file changed

Lines changed: 16 additions & 18 deletions

File tree

test/integration/viewer_spec.mjs

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe("PDF viewer", () => {
2828
describe("Zoom origin", () => {
2929
let pages;
3030

31-
beforeAll(async () => {
31+
beforeEach(async () => {
3232
pages = await loadAndWait(
3333
"tracemonkey.pdf",
3434
".textLayer .endOfContent",
@@ -38,7 +38,7 @@ describe("PDF viewer", () => {
3838
);
3939
});
4040

41-
afterAll(async () => {
41+
afterEach(async () => {
4242
await closePages(pages);
4343
});
4444

@@ -107,11 +107,11 @@ describe("PDF viewer", () => {
107107
describe("Zoom with the mouse wheel", () => {
108108
let pages;
109109

110-
beforeAll(async () => {
110+
beforeEach(async () => {
111111
pages = await loadAndWait("empty.pdf", ".textLayer .endOfContent", 1000);
112112
});
113113

114-
afterAll(async () => {
114+
afterEach(async () => {
115115
await closePages(pages);
116116
});
117117

@@ -141,11 +141,11 @@ describe("PDF viewer", () => {
141141
describe("Zoom commands", () => {
142142
let pages;
143143

144-
beforeAll(async () => {
144+
beforeEach(async () => {
145145
pages = await loadAndWait("tracemonkey.pdf", ".textLayer .endOfContent");
146146
});
147147

148-
afterAll(async () => {
148+
afterEach(async () => {
149149
await closePages(pages);
150150
});
151151

@@ -191,7 +191,7 @@ describe("PDF viewer", () => {
191191
describe("forced (maxCanvasPixels: 0)", () => {
192192
let pages;
193193

194-
beforeAll(async () => {
194+
beforeEach(async () => {
195195
pages = await loadAndWait(
196196
"tracemonkey.pdf",
197197
".textLayer .endOfContent",
@@ -201,7 +201,7 @@ describe("PDF viewer", () => {
201201
);
202202
});
203203

204-
afterAll(async () => {
204+
afterEach(async () => {
205205
await closePages(pages);
206206
});
207207

@@ -257,7 +257,7 @@ describe("PDF viewer", () => {
257257

258258
const MAX_CANVAS_PIXELS = new Map();
259259

260-
beforeAll(async () => {
260+
beforeEach(async () => {
261261
pages = await loadAndWait(
262262
"tracemonkey.pdf",
263263
".textLayer .endOfContent",
@@ -271,9 +271,7 @@ describe("PDF viewer", () => {
271271
return { maxCanvasPixels };
272272
}
273273
);
274-
});
275274

276-
beforeEach(async () => {
277275
await Promise.all(
278276
pages.map(async ([browserName, page]) => {
279277
const handle = await waitForPageRendered(page);
@@ -294,7 +292,7 @@ describe("PDF viewer", () => {
294292
);
295293
});
296294

297-
afterAll(async () => {
295+
afterEach(async () => {
298296
await closePages(pages);
299297
});
300298

@@ -387,15 +385,15 @@ describe("PDF viewer", () => {
387385
describe("Canvas fits the page", () => {
388386
let pages;
389387

390-
beforeAll(async () => {
388+
beforeEach(async () => {
391389
pages = await loadAndWait(
392390
"issue18694.pdf",
393391
".textLayer .endOfContent",
394392
"page-width"
395393
);
396394
});
397395

398-
afterAll(async () => {
396+
afterEach(async () => {
399397
await closePages(pages);
400398
});
401399

@@ -461,7 +459,7 @@ describe("PDF viewer", () => {
461459
function setupPages(zoom, devicePixelRatio, setups = {}) {
462460
let pages;
463461

464-
beforeAll(async () => {
462+
beforeEach(async () => {
465463
pages = await loadAndWait(
466464
"colors.pdf",
467465
null,
@@ -480,7 +478,7 @@ describe("PDF viewer", () => {
480478
);
481479
});
482480

483-
afterAll(async () => {
481+
afterEach(async () => {
484482
await closePages(pages);
485483
});
486484

@@ -1121,11 +1119,11 @@ describe("PDF viewer", () => {
11211119
);
11221120
}
11231121

1124-
beforeAll(async () => {
1122+
beforeEach(async () => {
11251123
pages = await loadAndWait("issue18694.pdf", ".textLayer .endOfContent");
11261124
});
11271125

1128-
afterAll(async () => {
1126+
afterEach(async () => {
11291127
await closePages(pages);
11301128
});
11311129

0 commit comments

Comments
 (0)