Skip to content

Commit 965949c

Browse files
committed
Isolate the text layer integration tests
To avoid being able to introduce dependencies between tests this commit makes sure that we close the document between tests so that we can't accidentally rely on state set by a previous test.
1 parent 6308f5e commit 965949c

1 file changed

Lines changed: 11 additions & 18 deletions

File tree

test/integration/text_layer_spec.mjs

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe("Text layer", () => {
5959
};
6060
}
6161

62-
beforeAll(() => {
62+
beforeEach(() => {
6363
jasmine.addAsyncMatchers({
6464
// Check that a page has a selection containing the given text, with
6565
// some tolerance for extra characters before/after.
@@ -111,13 +111,13 @@ describe("Text layer", () => {
111111
describe("doesn't jump when hovering on an empty area", () => {
112112
let pages;
113113

114-
beforeAll(async () => {
114+
beforeEach(async () => {
115115
pages = await loadAndWait(
116116
"tracemonkey.pdf",
117117
`.page[data-page-number = "1"] .endOfContent`
118118
);
119119
});
120-
afterAll(async () => {
120+
afterEach(async () => {
121121
await closePages(pages);
122122
});
123123

@@ -220,13 +220,13 @@ describe("Text layer", () => {
220220
describe("doesn't jump when hovering on an empty area, with .markedContent", () => {
221221
let pages;
222222

223-
beforeAll(async () => {
223+
beforeEach(async () => {
224224
pages = await loadAndWait(
225225
"chrome-text-selection-markedContent.pdf",
226226
`.page[data-page-number = "1"] .endOfContent`
227227
);
228228
});
229-
afterAll(async () => {
229+
afterEach(async () => {
230230
await closePages(pages);
231231
});
232232

@@ -318,22 +318,15 @@ describe("Text layer", () => {
318318
describe("when selecting over a link", () => {
319319
let pages;
320320

321-
beforeAll(async () => {
321+
beforeEach(async () => {
322322
pages = await loadAndWait(
323323
"annotation-link-text-popup.pdf",
324324
`.page[data-page-number = "1"] .endOfContent`
325325
);
326326
});
327-
afterAll(async () => {
327+
afterEach(async () => {
328328
await closePages(pages);
329329
});
330-
afterEach(() =>
331-
Promise.all(
332-
pages.map(([_, page]) =>
333-
page.evaluate(() => window.getSelection().removeAllRanges())
334-
)
335-
)
336-
);
337330

338331
it("allows selecting within the link", async () => {
339332
await Promise.all(
@@ -451,7 +444,7 @@ describe("Text layer", () => {
451444
let browser;
452445
let page;
453446

454-
beforeAll(async () => {
447+
beforeEach(async () => {
455448
// Chrome does not support simulating caret-based selection, so this
456449
// test only runs in Firefox.
457450
browser = await startBrowser({
@@ -472,7 +465,7 @@ describe("Text layer", () => {
472465
{ timeout: 0 }
473466
);
474467
});
475-
afterAll(async () => {
468+
afterEach(async () => {
476469
await closeSinglePage(page);
477470
await browser.close();
478471
});
@@ -542,7 +535,7 @@ describe("Text layer", () => {
542535
let browser;
543536
let page;
544537

545-
beforeAll(async () => {
538+
beforeEach(async () => {
546539
// Only testing in Firefox because, while Chrome has a setting similar to
547540
// font.minimum-size.x-western, it is not exposed through its API.
548541
browser = await startBrowser({
@@ -561,7 +554,7 @@ describe("Text layer", () => {
561554
);
562555
});
563556

564-
afterAll(async () => {
557+
afterEach(async () => {
565558
await closeSinglePage(page);
566559
await browser.close();
567560
});

0 commit comments

Comments
 (0)