Skip to content

feat(nimbus): Replace message risk question with message review process - #16725

Open
freshstrangemusic wants to merge 4 commits into
mainfrom
freshstrangemusic/push-zrkpoorvopmy
Open

feat(nimbus): Replace message risk question with message review process#16725
freshstrangemusic wants to merge 4 commits into
mainfrom
freshstrangemusic/push-zrkpoorvopmy

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

Because:

  • the existing message risk workflow was not meeting our needs:
    • it appeared on every experiment/rollout, regardless of whether or not it contained a message; and
    • it only asked "is this a message?" and did not actually record whether or not the process was followed.
  • we do not want to hard gate launching experiments/rollouts with required sign-offs (besides the pre-existing reviewer & Remote Settings checks).

this commit:

  • removing the existing messaging risk section;
  • adds a new "OMC" user group;
  • adds a new "can perform message review" permission flag that is granted to all members of the "OMC" group;
  • adds a new "message review" flag on the branches page which requires the "can perform message review" permission to toggle;
  • will display a banner warning on messaging experiments/rollouts that have do not have the message review flag set;
  • will display a new signoff checkbox in the launch controls when the message review flag is not set; and
  • makes some minor cleanups to the launch control JavaScript.

Fixes #16641

@freshstrangemusic freshstrangemusic added the pr-preview Create a preview environment label Aug 11, 2026
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from 8cd4b85 to 7d06108 Compare August 11, 2026 18:13
@freshstrangemusic
freshstrangemusic changed the base branch from main to freshstrangemusic/push-mnvkusrkzlxn August 11, 2026 18:13
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from 7d06108 to c8cd240 Compare August 11, 2026 18:18
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-mnvkusrkzlxn branch 2 times, most recently from f3c901d to a4e57e4 Compare August 11, 2026 18:44
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch 3 times, most recently from 6dc14dc to b22ec2c Compare August 11, 2026 19:59
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-mnvkusrkzlxn branch 2 times, most recently from 2c9e069 to d2b3358 Compare August 11, 2026 20:08
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch 2 times, most recently from 4eeb8e3 to e187ae0 Compare August 11, 2026 20:40
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-mnvkusrkzlxn branch from d2b3358 to 5cb51a9 Compare August 11, 2026 20:40
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from e187ae0 to aa0c292 Compare August 11, 2026 21:09
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-mnvkusrkzlxn branch from 5cb51a9 to bba5531 Compare August 11, 2026 21:09
@freshstrangemusic freshstrangemusic added pr-preview Create a preview environment and removed pr-preview Create a preview environment labels Aug 13, 2026
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from aa0c292 to 041488f Compare August 13, 2026 17:58
@freshstrangemusic
freshstrangemusic changed the base branch from freshstrangemusic/push-mnvkusrkzlxn to main August 13, 2026 18:03
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch 2 times, most recently from 9b65d78 to 9219e26 Compare August 13, 2026 18:55
@freshstrangemusic freshstrangemusic removed the pr-preview Create a preview environment label Aug 14, 2026
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from 9219e26 to 395fa74 Compare August 14, 2026 18:17
@freshstrangemusic freshstrangemusic added the pr-preview Create a preview environment label Aug 14, 2026
Because:

- the pr-preview workflow was disabled

this commit:

- re-adds the workflow as a separate workflow file; and
- removes the PR trigger for the main publish workflow.

Fixes #16729
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from 395fa74 to ff20ded Compare August 14, 2026 18:25
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from ff20ded to ddd244c Compare August 14, 2026 19:44
Because:

- the existing message risk workflow was not meeting our needs:
  - it appeared on every experiment/rollout, regardless of whether or
    not it contained a message; and
  - it only asked "is this a message?" and did not actually record
    whether or not the process was followed.
- we do not want to hard gate launching experiments/rollouts with
  required sign-offs (besides the pre-existing reviewer & Remote
  Settings checks).

this commit:

- removing the existing messaging risk section;
- adds a new "OMC" user group;
- adds a new "can perform message review" permission flag that is
  granted to all members of the "OMC" group;
- adds a new "message review" flag on the branches page which requires
  the "can perform message review" permission to toggle;
- will display a banner warning on messaging experiments/rollouts that
  have do not have the message review flag set;
- will display a new signoff checkbox in the launch controls when the
  message review flag is not set; and
- makes some minor cleanups to the launch control JavaScript.

Fixes #16641
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-zrkpoorvopmy branch from ddd244c to 63183be Compare August 14, 2026 20:34
@freshstrangemusic freshstrangemusic removed the pr-preview Create a preview environment label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a workflow for the message consult approval

1 participant