feat(nimbus): Replace message risk question with message review process - #16725
Open
freshstrangemusic wants to merge 4 commits into
Open
feat(nimbus): Replace message risk question with message review process#16725freshstrangemusic wants to merge 4 commits into
freshstrangemusic wants to merge 4 commits into
Conversation
freshstrangemusic
requested review from
RJAK11,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
August 11, 2026 16:01
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 11, 2026 18:13
8cd4b85 to
7d06108
Compare
freshstrangemusic
changed the base branch from
main
to
freshstrangemusic/push-mnvkusrkzlxn
August 11, 2026 18:13
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 11, 2026 18:18
7d06108 to
c8cd240
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnvkusrkzlxn
branch
2 times, most recently
from
August 11, 2026 18:44
f3c901d to
a4e57e4
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
3 times, most recently
from
August 11, 2026 19:59
6dc14dc to
b22ec2c
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnvkusrkzlxn
branch
2 times, most recently
from
August 11, 2026 20:08
2c9e069 to
d2b3358
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
2 times, most recently
from
August 11, 2026 20:40
4eeb8e3 to
e187ae0
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnvkusrkzlxn
branch
from
August 11, 2026 20:40
d2b3358 to
5cb51a9
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 11, 2026 21:09
e187ae0 to
aa0c292
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnvkusrkzlxn
branch
from
August 11, 2026 21:09
5cb51a9 to
bba5531
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 13, 2026 17:58
aa0c292 to
041488f
Compare
freshstrangemusic
changed the base branch from
freshstrangemusic/push-mnvkusrkzlxn
to
main
August 13, 2026 18:03
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
2 times, most recently
from
August 13, 2026 18:55
9b65d78 to
9219e26
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 14, 2026 18:17
9219e26 to
395fa74
Compare
Because: - the pr-preview workflow was disabled this commit: - re-adds the workflow as a separate workflow file; and - removes the PR trigger for the main publish workflow. Fixes #16729
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 14, 2026 18:25
395fa74 to
ff20ded
Compare
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 14, 2026 19:44
ff20ded to
ddd244c
Compare
Because:
- the existing message risk workflow was not meeting our needs:
- it appeared on every experiment/rollout, regardless of whether or
not it contained a message; and
- it only asked "is this a message?" and did not actually record
whether or not the process was followed.
- we do not want to hard gate launching experiments/rollouts with
required sign-offs (besides the pre-existing reviewer & Remote
Settings checks).
this commit:
- removing the existing messaging risk section;
- adds a new "OMC" user group;
- adds a new "can perform message review" permission flag that is
granted to all members of the "OMC" group;
- adds a new "message review" flag on the branches page which requires
the "can perform message review" permission to toggle;
- will display a banner warning on messaging experiments/rollouts that
have do not have the message review flag set;
- will display a new signoff checkbox in the launch controls when the
message review flag is not set; and
- makes some minor cleanups to the launch control JavaScript.
Fixes #16641
freshstrangemusic
force-pushed
the
freshstrangemusic/push-zrkpoorvopmy
branch
from
August 14, 2026 20:34
ddd244c to
63183be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #16641