feat(nimbus): Show single description link URL field for Fenix labs - #16711
Open
freshstrangemusic wants to merge 1 commit into
Open
feat(nimbus): Show single description link URL field for Fenix labs#16711freshstrangemusic wants to merge 1 commit into
freshstrangemusic wants to merge 1 commit into
Conversation
freshstrangemusic
requested review from
RJAK11,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
August 10, 2026 22:09
freshstrangemusic
force-pushed
the
freshstrangemusic/push-rkrttyuxvzno
branch
from
August 10, 2026 22:10
27a608e to
224c93b
Compare
Because:
- Firefox for Android only supports a single
firefox_labs_description_link key ("feedback"); and
- the default UI for this field is a JSON editor
This commit:
- replaces the editor with an input for a single link for Fenix Labs;
and
- this UI will work for future products that only support a single link
(e.g., iOS if we ever build it).
Fixes #16695
freshstrangemusic
force-pushed
the
freshstrangemusic/push-rkrttyuxvzno
branch
from
August 11, 2026 14:33
224c93b to
cd85712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Fixes #16695