Bug 2056990 - #2728
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds visibility-aware keyword counts to prevent leaking restricted security bug totals.
Changes:
- Recognizes
csectype-*as security keywords. - Filters keyword counts by group membership.
- Adds regression tests for restricted counts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Bugzilla/Keyword.pm |
Adds security classification and visibility-filtered counts. |
describekeywords.cgi |
Uses centralized security-keyword detection. |
t/bmo/keyword-security-count.t |
Tests classification and restricted counts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+99
to
+102
| # The reporter/assignee/qa/cc visibility exceptions (see | ||
| # Bugzilla::User->visible_bugs) are intentionally not applied here: ignoring | ||
| # them can only make a count lower than the user's true visibility, never | ||
| # higher, so no restricted data can leak. Using a conditional COUNT (rather |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2056990