Bug 2052985 - feat: include partial_versions in get_release_config#234
Open
kryoseu wants to merge 1 commit into
Open
Bug 2052985 - feat: include partial_versions in get_release_config#234kryoseu wants to merge 1 commit into
kryoseu wants to merge 1 commit into
Conversation
Port the partial_versions handling from `gecko_taskgraph`s `get_release_config` so gecko and comm can share a single implementation. When the `PARTIAL_UPDATES` environment variable is set (as done by the release_promotion action), a `partial_versions` entry describing the partial updates is added to the release config. The set of kinds that consume partials is project-specific, so rather than hardcoding gecko's kind names in shared code (which is how it's currently done in gecko_taskgraph) they are sourced from a new `partial-updates-kinds` list in the graph-config. `get_release_config` reads it from the graph config and only injects `partial_versions` for tasks whose kind is listed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the partial_versions handling from
gecko_taskgraphsget_release_configso gecko and comm can share a single implementation. When thePARTIAL_UPDATESenvironment variable is set (as done by the release_promotion action), apartial_versionsentry describing the partial updates is added to the release config.The set of kinds that consume partials is project-specific, so rather than hardcoding gecko's kind names in shared code (which is how it's currently done in gecko_taskgraph) they are sourced from a new
partial-updates-kindslist in the graph-config.get_release_configreads it from the graph config and only injectspartial_versionsfor tasks whose kind is listed.