Repository navigation
builder-upgrade: drop relops sudoers before the upgrade; expect pmset exec - #94
Merged
Merged
Conversation
… exec stop_worker now writes /etc/sudoers.d/zz-builder-upgrade while sudo still works. The upgrade resets /etc/sudoers to Apple's stock file, which reads sudoers.d, so if the drop-in survives the upgrade the sudo step no longer needs the SimpleMDM pkg, a password, or a person (r8-138 needed all three). Puppet's sudo class purges the dir on its first run under the new role. pmset_SleepDisabled runs on every puppet run, like the mercurial exec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS upgrade resets /etc/sudoers to stock, which cost relops its NOPASSWD rule on r8-138 and needed a person to put it back. stop_worker now writes /etc/sudoers.d/zz-builder-upgrade while sudo still works; stock sudoers reads sudoers.d, so the sudo step after the upgrade just works. Puppet's sudo class purges the drop-in on its first run under the new role.
Also adds Exec[pmset_SleepDisabled] to the execs expected on every puppet run, so the second-run idempotence check doesn't trip on it.