Repository navigation
runner: reject unknown job actions instead of running a reprovision - #90
Merged
Merged
Conversation
_job_cmd fell through to `reprovision run` for any action it didn't recognise, so a Hangar newer than the runner (e.g. builder-upgrade queued before the runner self-updated) would have turned into an EACS reprovision. Only "reprovision" or no action runs the workflow now; anything else fails the job with "unknown action" and starts nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_job_cmdfell through toreprovision runfor any action it didn't recognise, so a Hangar newer than the runner (say abuilder-upgradequeued before the runner self-updated to #89) would have turned into an EACS reprovision. Now onlyreprovisionor no action runs the workflow; anything else fails the job with "unknown action" and starts nothing.