Bug 2058158 - Remove jsonrpc.cgi and disallow the JSONRPC endpoint - #2691
Merged
Conversation
Also drops the now-dead references to it (Requirements.pm, Bugzilla.pm, Hook.pm POD, user-error.html.tmpl). JSONRPC.pm itself stays, since REST.pm still inherits from it.
- json_rpc_get_method_required - json_rpc_illegal_content_type - json_rpc_post_only
dklawren
approved these changes
Aug 4, 2026
| use constant FEATURE_FILES => ( | ||
| rest => ['Bugzilla/WebService/Server/REST.pm', 'rest.cgi'], | ||
| jsonrpc => ['Bugzilla/WebService/Server/JSONRPC.pm', 'jsonrpc.cgi'], | ||
| jsonrpc => ['Bugzilla/WebService/Server/JSONRPC.pm'], |
Collaborator
There was a problem hiding this comment.
the pod in Bugzilla/WebService/Server/JSONRPC.pm still documents jsonrpc.cgi as the endpoint (the CONNECTING and JSONP sections, plus the sample urls). We can leave it alone since this file will disappear completely in the future. No one reads the perldoc except for developers. It is not documented on readthedocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
jsonrpc.cgientry point and the now-dead references to it.Note:
Bugzilla::WebService::Server::JSONRPCitself stays, sinceREST.pmstill inherits from it.This is the third of a small set of child bugs cleaning up the old API surface, see 1599274 for details.
Changes
jsonrpc.cgiBugzilla.pm: drop the deadUSAGE_MODE_JSON/ jsonrpc branch inlog_user_requestBugzilla/Install/Requirements.pm: remove thejsonrpcFEATURE_FILES entryBugzilla/Hook.pm: fix the POD reference tojsonrpc.cgiuser-error.html.tmpl: remove JSON-RPC-specific error copyTest plan
/jsonrpc.cginow 404s./rest/...) still works -REST.pmstill subclassesJSONRPC.pm, so verify that inheritance path is unaffectedperl -c/ PPI sanity check on the touched core modulesReferences