Repository navigation
chore: release - #404
chore: release#404
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e49551c06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| web-transport-wasm = { version = "0.8.0", path = "../web-transport-wasm" } | ||
| web-transport-wasm = { version = "0.9.0", path = "../web-transport-wasm" } |
There was a problem hiding this comment.
Bump
web-transport before changing its WASM dependency
The parent release commit already declares web-transport version 0.13.1 and contains a 0.13.1 changelog entry, but this change only updates its dependency requirement while leaving the package version unchanged. That would attempt to change the contents of an already released crates.io version, which cannot be republished; consequently consumers of web-transport will continue receiving the previously published dependency on web-transport-wasm 0.8.0 rather than this 0.9.0 update. Increment the wrapper crate version and update the new changelog heading accordingly.
Useful? React with 👍 / 👎.
6e49551 to
5c4f448
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Direction: this is an appropriately small release PR. Keeping version/dependency updates separate from the transport implementation makes the release easier to audit; I would keep this approach rather than add release-specific abstractions.
No actionable introduced defect found in the ten changed manifests/changelogs. The earlier finding about reusing the wrapper crate's published version is addressed: web-transport now advances to 0.13.2 and selects web-transport-wasm 0.9.0.
Release validation: the PR records intentional WASM API incompatibilities. Validate the published package graph on wasm32 as well as native, including the facade's public wasm re-export; inspecting the native build alone does not establish browser compatibility.
Reviewed head: 5c4f448. Static review of the complete PR diff and relevant facade/release-tag context; I did not run builds or runtime tests. This comment is not a merge approval.
d7a3851 to
130173c
Compare
130173c to
44e036c
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 44e036c
No actionable new bugs found in the release changes since my previous review. The meaningful update is web-transport-wasm 0.9.0 -> 0.8.1 (rs/web-transport-wasm/Cargo.toml:8), with the facade requirement aligned at rs/web-transport/Cargo.toml:24. The WASM package source and dependency manifest are unchanged from the 0.8.0 release tag before this version bump. This supports a patch release and supersedes my earlier implication that this PR intentionally introduces WASM API incompatibilities; #410 explains the unrelated, yanked 0.10.0 baseline.
The earlier wrapper-version finding remains fixed: web-transport advances to 0.13.2. All six proposed package versions are absent from the registry index, and the facade's native/WASM requirements match the versions being released. Direction is sound: the small manifest/changelog update is sufficient; no extra release abstraction is needed.
Verification: static review of both release diffs, surrounding manifests/facade, release-tag comparison, and registry metadata. Exact-head CI is running; I did not run builds, tests, or a publication dry run. The WASM semver check remains disabled by #410, so native/WASM validation is still needed before release.
🤖 New release
qmux: 0.6.1 -> 0.6.2 (✓ API compatible changes)web-transport-quinn: 0.13.0 -> 0.13.1 (✓ API compatible changes)web-transport-wasm: 0.8.0 -> 0.8.1web-transport-iroh: 0.8.0 -> 0.8.1 (✓ API compatible changes)web-transport-noq: 0.4.0 -> 0.4.1 (✓ API compatible changes)web-transport: 0.13.1 -> 0.13.2Changelog
qmuxweb-transport-quinnweb-transport-wasmweb-transport-irohweb-transport-noqweb-transportThis PR was generated with release-plz.