-
Notifications
You must be signed in to change notification settings - Fork 0
Add moxygen interoperability smoke lane #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| #!/usr/bin/env bash | ||
| # Protocol-level interoperability smoke test using moxygen's published client. | ||
| # | ||
| # This is separate from smoke.sh's Hang media matrix: moxygen uses MoQ Media | ||
| # Interop packaging, while this client exercises transport setup, namespace | ||
| # publication, subscription errors, and publisher/subscriber routing directly. | ||
| set -euo pipefail | ||
|
|
||
| MOQ_REPO="https://github.com/moq-dev/moq" | ||
| MOQ_RELAY="${MOQ_RELAY_BIN:-}" | ||
| DOCKER="${MOXYGEN_DOCKER:-docker}" | ||
| MOXYGEN_IMAGE="${MOXYGEN_IMAGE:-ghcr.io/facebookexperimental/moxygen-interop-client:latest-amd64}" | ||
| PORT="${MOXYGEN_SMOKE_PORT:-4444}" | ||
| TIMEOUT="${MOXYGEN_SMOKE_TIMEOUT:-45}" | ||
| VERSION="${MOXYGEN_MOQT_VERSION:-16}" | ||
| HTTPS_URL="https://127.0.0.1:${PORT}" | ||
| MOQT_URL="moqt://127.0.0.1:${PORT}" | ||
| CONTAINER_PREFIX="moxygen-smoke-$$" | ||
|
|
||
| TMP=$(mktemp -d) | ||
| RELAY_PID="" | ||
|
|
||
| have() { command -v "$1" >/dev/null 2>&1; } | ||
|
|
||
| # shellcheck disable=SC2329 # invoked indirectly via 'trap cleanup EXIT' | ||
| kill_tree() { | ||
| local pid="$1" child | ||
| for child in $(pgrep -P "$pid" 2>/dev/null || true); do kill_tree "$child"; done | ||
| kill -KILL "$pid" 2>/dev/null || true | ||
| } | ||
|
|
||
| # shellcheck disable=SC2329 # invoked indirectly via 'trap cleanup EXIT' | ||
| cleanup() { | ||
| "$DOCKER" rm -f "${CONTAINER_PREFIX}-webtransport" "${CONTAINER_PREFIX}-quic" >/dev/null 2>&1 || true | ||
| [[ -n "$RELAY_PID" ]] && kill_tree "$RELAY_PID" | ||
| rm -rf "$TMP" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| missing=() | ||
| for tool in curl openssl pgrep timeout "$DOCKER"; do | ||
| have "$tool" || missing+=("$tool") | ||
| done | ||
| if [[ -z "$MOQ_RELAY" ]]; then | ||
| have cargo || missing+=("cargo") | ||
| fi | ||
| if [[ ${#missing[@]} -gt 0 ]]; then | ||
| echo "error: missing required tools: ${missing[*]}" >&2 | ||
| exit 1 | ||
| fi | ||
| if ! "$DOCKER" info >"$TMP/docker-info.log" 2>&1; then | ||
| echo "error: $DOCKER daemon is not running" >&2 | ||
| sed 's/^/ /' "$TMP/docker-info.log" >&2 || true | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ -z "$MOQ_RELAY" ]]; then | ||
| echo "building moq-relay from $MOQ_REPO (latest default branch)..." | ||
| if cargo install --quiet --locked --git "$MOQ_REPO" \ | ||
| --root "$TMP/moq-install" --target-dir "$TMP/moq-target" moq-relay \ | ||
| >"$TMP/moq-relay-build.log" 2>&1; then | ||
| MOQ_RELAY="$TMP/moq-install/bin/moq-relay" | ||
| else | ||
| echo "error: failed to build moq-relay" >&2 | ||
| sed 's/^/ /' "$TMP/moq-relay-build.log" >&2 || true | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| [[ -x "$MOQ_RELAY" ]] || { | ||
| echo "error: moq-dev relay is not executable: $MOQ_RELAY" >&2 | ||
| exit 1 | ||
| } | ||
|
|
||
| echo "pulling moxygen interop client: $MOXYGEN_IMAGE" | ||
| if ! "$DOCKER" pull --platform linux/amd64 "$MOXYGEN_IMAGE" >"$TMP/docker-pull.log" 2>&1; then | ||
| echo "error: failed to pull moxygen interop client" >&2 | ||
| sed 's/^/ /' "$TMP/docker-pull.log" >&2 || true | ||
| exit 1 | ||
| fi | ||
|
|
||
| # The relay requires certificate files. The moxygen client disables verification | ||
| # only for this loopback test. | ||
| if ! openssl req -x509 -newkey rsa:2048 -nodes \ | ||
| -keyout "$TMP/localhost.key" -out "$TMP/localhost.crt" -days 1 \ | ||
| -subj /CN=localhost -addext subjectAltName=DNS:localhost,IP:127.0.0.1 \ | ||
| >"$TMP/openssl.log" 2>&1; then | ||
| echo "error: failed to generate the temporary relay certificate" >&2 | ||
| sed 's/^/ /' "$TMP/openssl.log" >&2 || true | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "starting moq-dev relay on 127.0.0.1:${PORT}..." | ||
| "$MOQ_RELAY" --server-bind "127.0.0.1:${PORT}" \ | ||
| --tls-cert "$TMP/localhost.crt" --tls-key "$TMP/localhost.key" \ | ||
| --web-https-listen "127.0.0.1:${PORT}" \ | ||
| --web-https-cert "$TMP/localhost.crt" --web-https-key "$TMP/localhost.key" \ | ||
| --auth-public "" >"$TMP/relay.log" 2>&1 & | ||
| RELAY_PID=$! | ||
|
|
||
| ready=0 | ||
| for _ in $(seq 1 60); do | ||
| if curl --cacert "$TMP/localhost.crt" -sf "$HTTPS_URL/certificate.sha256" >/dev/null 2>&1; then | ||
| ready=1 | ||
| break | ||
| fi | ||
| kill -0 "$RELAY_PID" 2>/dev/null || break | ||
| sleep 0.5 | ||
| done | ||
| if [[ "$ready" -ne 1 ]]; then | ||
| echo "error: moq-dev relay never became ready" >&2 | ||
| sed 's/^/ relay: /' "$TMP/relay.log" >&2 || true | ||
| exit 1 | ||
| fi | ||
|
|
||
| overall=0 | ||
| run_transport() { | ||
| local transport="$1" url="$2" name | ||
| name="${CONTAINER_PREFIX}-${transport}" | ||
| echo "=== moxygen / moq-dev / $transport / draft-$VERSION ===" | ||
| if timeout -k 3 "$TIMEOUT" "$DOCKER" run --rm \ | ||
| --name "$name" --network host --platform linux/amd64 \ | ||
| "$MOXYGEN_IMAGE" --relay "$url" --tls_disable_verify \ | ||
| --versions "$VERSION" >"$TMP/$transport.tap" 2>&1; then | ||
| sed 's/^/ /' "$TMP/$transport.tap" | ||
| else | ||
| echo " FAIL moxygen interop client" >&2 | ||
| sed 's/^/ client: /' "$TMP/$transport.tap" >&2 || true | ||
| sed 's/^/ relay: /' "$TMP/relay.log" >&2 || true | ||
| overall=1 | ||
| fi | ||
| "$DOCKER" rm -f "$name" >/dev/null 2>&1 || true | ||
| } | ||
|
|
||
| # moxygen recommends draft-16 for new integrations while its draft-18 support | ||
| # remains experimental. Pinning the wire draft is intentional; both source-head | ||
| # implementations are still refreshed on every run. | ||
| run_transport webtransport "$HTTPS_URL" | ||
| run_transport quic "$MOQT_URL" | ||
|
|
||
| if [[ "$overall" -eq 0 ]]; then | ||
| echo "moxygen interop smoke: all checks passed" | ||
| else | ||
| echo "moxygen interop smoke: FAILURES detected" >&2 | ||
| fi | ||
| exit "$overall" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major
Keep unrelated
moxygen.shfailures blocking.continue-on-error: trueapplies to the entire interoperability step. It can hide relay setup failures, image-pull failures, and unrelated transport failures. Makemoxygen.shreturn zero in CI only whenannounce-subscribeis the sole known failure, then remove this step-level flag.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 1-277: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents