Skip to content

fix(proto): make BBR respond to classic ECN #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 4 commits into from
Sep 27, 2026
Merged

fix(proto): make BBR respond to classic ECN #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5655cc
fix(proto): make BBR respond to classic ECN
kixelated Sep 26, 2026
039130b
fix(proto): bound a CE-stopped probe by the ACK's rate sample
kixelated Sep 26, 2026
7664b06
fix(proto): bound a CE-stopped probe only by the marked ACK's own sample
kixelated Sep 26, 2026
c85041b
fix(proto): bound a CE-stopped probe by the ACK's own sample
kixelated Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion noq-proto/src/congestion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ pub trait Controller: Send + Sync + std::fmt::Debug {
/// lost.
/// `lost_bytes` indicates how many bytes were lost. This value will be 0 for ECN triggers.
/// `largest_lost` identifies the packet with the highest packet number in the congestion
/// event.
/// event, and `sent` is its send time. For ECN, that is the largest packet acknowledged by
/// the ACK whose CE count increased, and the event fires only on such an increase.
///
/// Defaults to the deprecated [`Self::on_congestion_event`], dropping the space.
fn on_congestion_event_space(
Expand Down
Loading
Loading