quest(m1): plan the audio-quality and wire-compat follow-ups by kixelated · Pull Request #5445 · moq-dev/moq

kixelated · 2026-10-13T19:38:20Z

Plans follow-ups from #5442 (audio-quality budgets) and #5444 (wire compat on main).

quest/m1/audio-jitter-target/aac-bursty-restall.md [M]: AAC bursty rows stall 19-43% of every nightly window.
quest/m1/audio-jitter-target/opus-isolated-target.md [S]: Opus near-zero on the isolated ring reaches a 100-800 ms target while the postMessage ring holds 60 ms.
quest/m1/wire-compat-media.md [S]: same-version media cells keep the compat reader's media path covered while planned breaks skip the cross-version ones.

Watch now requires the two audio quests, and the audio-jitter-target epic lists them.

Decisions

Typecheck compat/*.ts follow-up (already typechecked against checkout packages by just js check)

✅ Drop it
Typecheck against the released packages

AAC bursty re-stall and Opus isolated-ring blow-up overlap Watch. How to scope them?

✅ Children Watch requires: reproducible from the nightly harness now; Watch's manual proof runs after them
Fold into Watch
Standalone, unlinked

Same-version media cell: confirm the goal and act

✅ Confirm, m1
Confirm, m0
Drop it

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-10-13T19:38:40Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T19:41:42.740093Z	`c8e3ea1`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8e3ea1a0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-13T19:41:40Z

+Compare what each ring reports as arrival and consumption to the estimator:
+an isolated ring that under-reports its fill, reads the worklet's position
+late, or misses a resize would underrun on its own and feed that back as
+measured jitter. Fix it at the source with a regression that fails without


Separate ring underruns from target inflation

The ring cannot feed its state back into the measured jitter as claimed here: Decoder.#runLegacyDecoder derives the target from consumer.spread, while Container.Consumer.#runGroup records that spread directly from transport frame arrivals before ring consumption. Under-reported fill, a late worklet position, or a missed resize can explain underruns, but not the 100–800 ms target_ms_p95; the quest should first compare captured arrivals and configuration between the two browser rows rather than directing the target investigation into the ring.

AGENTS.md reference: AGENTS.md:L16-L16

Useful? React with 👍 / 👎.

Agreed: consumer.spread is recorded in the container consumer before the ring, so a ring defect explains underruns but not the 100-800 ms target. bd34293 splits the two: compare the rows' captured arrivals and configuration first for the target, and look at the ring for the underruns.

(Written by Claude Opus 5.5)

chatgpt-codex-connector · 2026-10-13T19:41:40Z

+
+`just test wire-compat` runs at least one current-to-current and one
+released-to-released media cell through the compat reader
+(`test/interop/compat/client.ts`, selected by `INTEROP_COMPAT_CLIENT`), so a


Point the control cells at the real media reader

Neither this selector nor the described reader exists: test/interop/compat/client.ts has no media-subscribe command, and the harness selects the staged media reader at test/interop/clients/js-native/subscribe.ts via INTEROP_NATIVE_CLIENT. Implementing the quest literally therefore cannot exercise the reader's media path; name the existing subscriber and selector, or explicitly plan the new selector and reader wiring.

Useful? React with 👍 / 👎.

Disagree on the premise: #5444 (open) adds subscribe to test/interop/compat/client.ts and replaces INTEROP_NATIVE_CLIENT with INTEROP_COMPAT_CLIENT in interop.sh, so the names are right once it lands. bd34293 states that the quest starts after #5444 merges.

(Written by Claude Opus 5.5)

…5442/#5444 starts The playout target follows the container's arrival spread, recorded before the ring, so a ring defect explains underruns but not target growth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated

Automated review by review (OpenAI)

Reviewed bd34293 against 52dbffa, including all six planning files and relevant audio/interop code.

No remaining actionable bugs found. The previously identified ring-to-estimator feedback claim is fixed: the plan now compares captured arrivals/configuration first and separates target inflation from playback underruns. This also addresses the independent finding: #5445 (comment).

The #5442/#5444 prerequisites are explicit; #5444 actually supplies the named compat reader and selector, so the separate missing-selector finding does not apply after that prerequisite. Same-version control cells with a deliberately broken decoder and reproducible audio cases are appropriately scoped, without a second harness.

Nonblocking: treat the isolated-page explanation as a hypothesis; the remaining introductory 'not the estimator' wording is stronger than the evidence from separately run rows.

Verification: static GitHub-only plan/source review. No tests run or causal explanation independently reproduced.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated · 2026-10-13T19:46:46Z

Merge summary at b3e8785.

Codex: the isolated-ring quest claimed ring defects feed back into measured jitter, but consumer.spread is recorded before the ring. Fixed: the quest now compares the rows' arrivals and configuration first for the target, and the ring only for the underruns. The isolated page is named as a suspect, not a conclusion (from the OpenAI review's nonblocking note).
Codex: the compat reader's subscribe and INTEROP_COMPAT_CLIENT don't exist on main. They arrive with test(interop): released wire compat runs its own observer again #5444; the wire-compat quest now says it starts after test(interop): released wire compat runs its own observer again #5444 merges, and both audio quests say they start after test(audio-quality): measure the browser budgets on the nightly runner #5442 merges.
OpenAI review of bd34293: no actionable findings. The last push only softens one sentence.

The scoping decisions in the description were the maintainer's. CI passes; quest check is clean.

(Written by Claude Opus 5.5)

coderabbitai · 2026-10-13T19:47:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a7ad91c1-b664-4032-b6fa-31eac712865a

📥 Commits

Reviewing files that changed from the base of the PR and between 52dbffa and b3e8785.

📒 Files selected for processing: 6

quest/m1/README.md
quest/m1/audio-jitter-target/README.md
quest/m1/audio-jitter-target/aac-bursty-restall.md
quest/m1/audio-jitter-target/opus-isolated-target.md
quest/m1/audio-jitter-target/watch.md
quest/m1/wire-compat-media.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

Adds quest documents for wire-compat media coverage, AAC bursty-delivery re-stalls, and the Opus isolated-ring target. Adds required-quest links for these items.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to b3e87

The new quest documentation and required links are internally consistent; no merge-blocking risk was identified.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Description check		The description clearly summarizes the three planned follow-ups, their scope, decisions, dependencies, and lack of API or wire changes.
Title check		The title concisely describes the main change: planning audio-quality and wire-compat follow-ups for milestone m1.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

✨ Simplify code

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

quest(m1): plan the audio-quality and wire-compat follow-ups

c8e3ea1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

kixelated mentioned this pull request Oct 13, 2026

test(interop): released wire compat runs its own observer again #5444

Merged

kixelated commented Oct 13, 2026

View reviewed changes

quest(m1): the isolated page is a suspect, not a conclusion

b3e8785

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated enabled auto-merge October 13, 2026 19:46

kixelated added this pull request to the merge queue Oct 13, 2026

Merged via the queue into main with commit c308309 Oct 13, 2026
3 checks passed

kixelated deleted the claude/plan-audio-compat-followups branch October 13, 2026 19:58

Navigation Menu

Repository navigation

quest(m1): plan the audio-quality and wire-compat follow-ups - #5445

quest(m1): plan the audio-quality and wire-compat follow-ups#5445
kixelated merged 3 commits into
mainfrom
claude/plan-audio-compat-followups

kixelated commented Oct 13, 2026 •

edited by blacksmith-sh Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Uh oh!

kixelated Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Uh oh!

kixelated Oct 13, 2026

Uh oh!

kixelated left a comment

Uh oh!

kixelated commented Oct 13, 2026

Uh oh!

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kixelated commented Oct 13, 2026 • edited by blacksmith-sh Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Decisions

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

kixelated Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

kixelated Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

kixelated left a comment

Choose a reason for hiding this comment

Uh oh!

kixelated commented Oct 13, 2026

Uh oh!

coderabbitai Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kixelated commented Oct 13, 2026 •

edited by blacksmith-sh Bot

Loading

chatgpt-codex-connector Bot commented Oct 13, 2026 •

edited

Loading

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading