Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Relay tokens need the same verification and lease lifecycle as URL credentials, unioned authorization, real expiry, and bounded pending work. Current main does not implement that integration.
Approach
Preserve the quest and record the concrete integration blockers found in the code. The open request-token PR #5148 already introduces the persistent Connection auth handle, Request auth passthrough, and scoped requests on the same consumer. This draft deliberately avoids creating a competing API. Recommended landing order is #5148, then this quest.
Impact
Alternatives
Stack implementation on #5148 (recommended); port its unpublished API into this branch, creating competing integration work; or design an independent persistent handle, risking token loss and incompatible APIs. For queued work, prefer a bounded pending set that prunes withdrawn streams while preserving arrival order; a bounded FIFO alone leaves closed requests occupying every slot.
Validation
Read the relay admission/supervision, moq-auth Client/Driver/lease, auth acceptor queue, and #5148.
quest checkpasses. This is an investigation-only draft with no runtime change and no fabricated test or benchmark results.Unresolved decisions
The current Client Driver always posts
endwhen a lease ends. An attached token must never end the owning connection or release its session-limit slot. Recommendation: store owning connection identity and lifecycle ownership in the lease, and have attach produce a non-owning lease after checking the request identity. The auth server must hold multiple grants under one session id without double-counting or replacing that session. The per-session pending cap and overflow refusal remain to be selected with the integrated request-token queue.Follow-ups
The retained quest contains the required union/expiry/refusal/mTLS/outage cases and documentation work. Implement those after the shared AUTH API settles. This draft is not a completed relay-refresh feature.
(Written by GPT-6)