Skip to content

quest(m1): delete pool-churn-cursors, done by #5182 - #5255

Merged
kixelated merged 1 commit into
mainfrom
quest/delete-pool-churn-cursors
Oct 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/delete-pool-churn-cursors

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

This deletes quest/m1/pool-churn-cursors.md, which was planned in #5246. #5182 already added an origin/pool_cursors benchmark that sweeps paths (100/1k/10k) against cursors (1/100/1k). Cursor cost grows roughly additively: 10k paths take 46 ms with 1 cursor and 63 ms with 1k. The quest's remaining gap, a scoped cursor in the sweep, is too small to track on its own (maintainer decision, 2026-10-10).

The only reference, in the m1 README, is removed. quest check passes. Public API: none. Wire: none.

Decision paper trail

  • Pool bench quest: ✅ Delete it / Shrink it / Keep as is

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T21:10:45.334213Z a008875 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated enabled auto-merge October 10, 2026 21:09
@kixelated

Copy link
Copy Markdown
Collaborator Author

Reviewed head a008875d.

Small docs-only cleanup, and the claims hold up. #5182 is merged, and bench_pool_cursors (group origin/pool_cursors) exists in rs/moq-net/benches/origin.rs on main and is registered in the criterion group. A repo search finds no other references to pool-churn-cursors besides the README line this PR removes, so there are no dangling links.

Non-blocking: the deleted quest asked for the cursor axis on bench_pool_churn, but it actually landed as a separate bench_pool_cursors bench. That's fine, just worth knowing if anyone goes looking for it in pool_churn. The 46 ms and 63 ms figures in the body aren't recorded anywhere in the repo, so I couldn't check them.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed the full two-file diff at a008875 against base 954505e. No actionable findings.

The existing independent review reaches the same conclusion. I independently confirmed #5182 is merged and the pool cursor benchmark sweeps the stated axes. Given the documented decision to drop the remaining scoped-cursor follow-up, deleting the quest and its README entry is a proportionate cleanup; no replacement mechanism is needed.

Verification limits: GitHub-only static review. Search returned only the removed README reference, but indexing is not a complete head-specific link check. I did not run quest check or benchmarks; the timing figures are reported measurements from #5182, not independently reproduced results.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f8d5af14-aac1-4af9-a0c7-a9d28fb5dd12

📥 Commits

Reviewing files that changed from the base of the PR and between 954505e and a008875.


📒 Files selected for processing (2)
  • quest/m1/README.md
  • quest/m1/pool-churn-cursors.md

💤 Files with no reviewable changes (2)
  • quest/m1/README.md
  • quest/m1/pool-churn-cursors.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.



Walkthrough

The “Pool churn cursors” quest entry was removed from the m1 Required list. Its benchmark plan, which proposed measuring renewal cost across announce cursor counts, was deleted.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to a0088

The quest can be removed without changing runtime behavior. The cursor-count benchmark exists, and the remaining scoped-cursor gap was explicitly accepted.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the deletion of the pool-churn-cursors quest, the related benchmark work, and the removal of its README reference.
Title check Passed The title clearly identifies the deletion of the pool-churn-cursors quest and matches the main changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit cabdaf2 Oct 10, 2026
4 checks passed
@kixelated
kixelated deleted the quest/delete-pool-churn-cursors branch October 10, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant