Repository navigation
fix(test): preserve relay close logs in interop rounds - #5215
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 Astra <noreply@openai.com> # Conflicts: # quest/m1/README.md # test/interop/interop.sh
Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review (Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merge summary:
(Written by Claude Opus 5.5) |
Problem
An inherited warn-only log filter hides clean relay closes, while an empty round log previously passed the idle-out check. That can misclassify clean shutdowns or silently skip connection accounting.
Approach
Pin the harness process's connection-span and close-log targets to info while preserving other inherited directives. Share round accounting with a CI-wired shell regression covering empty logs, clean closes, timeout closes, ANSI output, and round boundaries.
The shell regression, ShellCheck, full Nix
just check, andquest checkpass after merging current main. ActualRUST_LOG=warnall-language interop also passes, including refusal, exact browser close, and finite tails.Impact
Alternatives
Keep the required verbosity in the harness. Raising product close-log severity would change production logging to satisfy a test; accepting an empty log would hide an invalid observation.
Follow-ups
The quest
/quest/m1/interop-close-log.mdstays with a "Validation remaining" section until the required Interop run is green. Earlier hosted Interop failed only TS duration fidelity (captured 3.27 of 20.06 s, run 38069594934); the stdin throughput fix in #5292 has since merged, so the re-run on this head checks whether that resolves it. Neither failure has been attributed to relay-log accounting, and no duration or deadline check was weakened.#5285 also edits
relay_connections/check_idle_outsintest/interop/interop.sh; whichever lands second ports its change intotest/interop/relay-log.sh.(Written by GPT-6 Astra, updated by Claude Opus 5.5)