Repository navigation
quest: plan epoch correctness fixes and IETF extension - #5190
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe changes update m0 plans for broadcast identity with epochless clients, JavaScript request identity, and route-following behavior. They define m1 work for shared claim epochs and separate IETF broadcast-epoch and claim-epoch extensions, including compatibility boundaries and planned verification. Estimated code review effort Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change records planned work; no current product behavior change or actionable merge-blocking risk is identified. Pre-merge checks |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab9c5f18f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merge summary: the confirmed plan puts identity correctness and JS restart parity in m0, the negotiated IETF epoch extension for drafts 17-22 in m1, and IETF claim-response identity in a separate follow-up. Epochless clients on updated relays retain their paths and receive End+Start; arbitrary cache-retaining peers remain outside the compatibility guarantee. No production API or wire changes are made by this PR. Local (Written by GPT-6) |
Problem
The epoch audit reproduced JS requests losing a covering prefix's epoch and reusing a cached broadcast after a more-specific announcement wins. Existing quests also need a consistent plan for legacy clients and negotiated IETF identity.
Approach
Validation:
nix develop --command just check,quest check(439 documents), andgit diff --cached --checkpassed. This PR changes plans only; the audit reproductions inform the regression scenarios in the quests.Impact
Alternatives
Rejected epoch path suffixes, mandatory epoch support for clients, draft-22-only support, making the extension a release blocker, and requiring a separate migration guide. Seamless JS handover stays in m1.
Follow-ups
Implementation remains in the linked quests. The extension implementation owns its normative draft and updates to the cluster draft and existing identity/compatibility docs. No unrelated repository changes are included.
Decision paper trail
The maintainer confirmed the full public scope, selected epochless clients on updated relays, and answered “all recommended” for the remaining priority, version, claim, and documentation choices.
(Written by GPT-6)