Repository navigation
quest: plan the paused spinner and A/V sync across a break #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e663629
quest: plan the paused spinner, A/V sync across a break, and visible …
kixelated a63123f
quest: drop the back-merge conflict quest; the workflow is being removed
kixelated c6b7479
Merge remote-tracking branch 'origin/main' into HEAD
kixelated a786e42
quest: a demand break is the viewer leaving, not a publisher pause
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # [XS] The watch buffering spinner never covers the paused play button | ||
|
|
||
| ## Goal | ||
|
|
||
| While `<moq-watch>` is paused, its buffering indicator stays hidden, so the | ||
| centre play button is always clickable, and Interop's resume step never times | ||
| out on it. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found in #5174 (2026-10-10): in Interop run 38013145379 the `cpp -> js` cell | ||
| failed because, after pause, audio stalling raised the buffering spinner | ||
| (`js/watch/src/ui/components/buffering-indicator.ts`) over the play button, | ||
| and the harness's resume click timed out. Planned in m0, decided 2026-10-10, | ||
| because it reddens Interop on unrelated PRs. | ||
|
|
||
| Buffering is not a meaningful state while paused: hide the indicator whenever | ||
| playback is paused, and show it again only once playback resumes and still | ||
| stalls. Add a browser test that pauses during an audio stall and clicks | ||
| resume. No harness workaround such as clicking elsewhere or waiting longer. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [S] A player stays in sync across a demand break | ||
|
|
||
| ## Goal | ||
|
|
||
| After a demand break (the viewer leaves and returns), | ||
| `@moq/watch` never plays pre-break audio out of sync with pre-break video: it | ||
| either plays them together or jumps straight to live. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found in #5173 (2026-10-10): in one reattach sample of `just test media`, | ||
| after the break the player played the old pre-break audio about 1.6 s apart | ||
| from the old video before jumping to live. Decided 2026-10-10: plan it as a | ||
| player bug. | ||
|
|
||
| Reproduce in the media fixture's reattach case, measuring the audio-video | ||
| offset of the first frames presented after the break. Find whether audio and | ||
| video take different groups from the relay after the break (the relay hands | ||
| the reachable pre-gap GOP by design, per #4914 and #5158) or the player's | ||
| sync re-anchors one track and not the other. Fix it at that cause, and assert | ||
| the offset in the media check. | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| Public API: none expected. Wire: none. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.