Skip to content

quest: plan the Interop close-code and TS duration-fidelity flakes - #5169

Merged
kixelated merged 1 commit into
mainfrom
quest/plan-interop-flakes
Oct 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/plan-interop-flakes

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Adds two quests under quest/m1/test-flakes-2/ for Interop flakes that #5158 hit and nothing tracked:

  • interop-close-code.md [S]: the browser close-code test saw "Connection lost" instead of "unauthorized" for a refused session.
  • ts-duration-fidelity.md [S]: TS compliance captured 3.3 s of a 20.1 s source.

The browser-audio timeouts in * -> js cells are left to quest/m0/ffi-publisher-stall.md, which is in progress.

Public API: none (planning only). Wire: none.

Decision paper trail

  • Untracked Interop flakes: ✅ Two quests under test-flakes-2 / Interop-stability questline / Wait for ffi-publisher-stall
  • Make Interop required: ✅ Not until it's green / Plan it as a quest / No

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cd75b4c9-9bf7-424a-b17d-e91a727f2874

📥 Commits

Reviewing files that changed from the base of the PR and between 1eb5aeb and 7fc6c38.


📒 Files selected for processing (3)
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/interop-close-code.md
  • quest/m1/test-flakes-2/ts-duration-fidelity.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T03:10:43.281352Z 7fc6c38 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review of 7fc6c383 (quest/docs-only)

Adds two cause-first flake quests (Interop close code, TS duration fidelity) and links them from the test-flakes-2 README.

Checked against main: test/interop/clients/js/close.ts exists and expects SessionCode.Unauthorized / "unauthorized" for the refused session, and test/ts/run.sh exists with a 20 s default duration, which matches the "20.1 s source" claim. The README links resolve to the new files. No blocking issues.

Non-blocking:

  • ts-duration-fidelity.md says the duration check lives in test/ts/run.sh; duration-fidelity itself doesn't appear by name in run.sh, so it's worth naming the file that actually asserts it, so whoever picks this up starts in the right place.
  • The new README entries go between "Impaired handshake" and "Cluster burst overrun". That's fine if the list is unordered; if it's meant to be in priority order, double-check the placement.
  • The dependency on feat!: TS export lingers within an epoch, --stitch switches programs #5147 is only stated in the plan. If that PR changes how an export ends, consider listing it in a Required line so the ordering is explicit.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 7fc6c38

No concrete bugs found in this documentation-only change. The two small, independently scoped investigations fit the parent quest's cause-first approach; requiring regressions while preserving close-code and duration assertions is appropriate, with no unnecessary implementation complexity introduced.

Checked all three changed files and the referenced browser close test, TS capture harness, and duration-fidelity analyzer. The README links resolve, and the #5147 cross-check is relevant to export termination. Static GitHub review only: I did not reproduce the flakes, run tests, or verify the historical CI failure measurements.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: adds two cause-first quests under the test-flakes-2 questline, interop-close-code.md (refused session reported as "Connection lost" instead of unauthorized) and ts-duration-fidelity.md (TS export captured 3.3 s of a 20.1 s source), both linked in the questline README. No changes to the decisions recorded in the PR body. Reviewed on head 7fc6c38 by the OpenAI review (no findings) and Codex (thumbs-up); main has not moved since the base, so no merge was needed. Enabling auto-merge pinned to the head SHA; it lands once Check and Test pass.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 10, 2026 03:19
@kixelated
kixelated merged commit e348cbe into main Oct 10, 2026
5 checks passed
@kixelated
kixelated deleted the quest/plan-interop-flakes branch October 10, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant