Skip to content

docs(concept): list the relay's moq-transport deviations - #5022

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/ietf-deviations-doc
Oct 8, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/ietf-deviations-doc

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Fastly's moq-relay-interop report flagged three answers this relay gives on purpose. Nothing in doc/concept/standard.md named them, so the next interop run had nowhere to point.

Approach

Under moq-transport, list the three deviations, each with its reason and the draft section that states the rule we do not follow. Behavior is unchanged.

  • One publisher per broadcast path. A SUBSCRIBE goes to one route, not to every matching publisher, because a path names one content. The rule is draft 16 §8.5. Route choice stays on the moq-lite publisher epochs page.
  • Unknown object properties are dropped, not forwarded, because the model carries only a payload and a timestamp. The rule is draft 18 §2.5. The rest of what moq-lite leaves out stays on that page.
  • A moq-lite 01 through 04 source has no track stream, so a moq-transport subscriber gets SUBSCRIBE_OK before that source answers. A missing track ends as PUBLISH_DONE, not REQUEST_ERROR. The rule is draft 16 §8.4.

The quest text cited draft 16 §8.4 for the fan-out. That section is the established-subscription rule. The "all matching publishers" sentence is §8.5, so the page cites each rule where the draft states it.

This completes quest/m1/ietf-deviations-doc from #5020. That PR owns the quest tree, and the quest file is not on main, so this branch leaves quest/ untouched. Delete the quest file and every reference once #5020 merges.

Impact

  • Public API: none.
  • Wire: none.

Alternatives

Changing the relay to fan out, forward unknown properties, or wait for an old lite source was declined on 2026-10-07. These are the product's model.

Follow-ups

  • After quest: triage Fastly's moq-relay-interop report #5020 merges, delete quest/m1/ietf-deviations-doc and its references. No separate quest.
  • Draft 18 §2.5 also requires unknown track properties to be forwarded. This relay drops those too, and this page only names object properties, which is what the report flagged. Add the track-property sentence only if a later interop run cares.

(Written by Grok 4.7)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: documented the three deliberate moq-transport deviations in doc/concept/standard.md and left behavior alone. just check passed. No open product decision. The fan-out rule is cited as draft 16 §8.5 and the early SUBSCRIBE_OK as §8.4, which is where those sentences live.

The quest file stays on #5020. Delete quest/m1/ietf-deviations-doc after that PR merges.

Recommendation: /quest-merge once a non-Grok review is in. This is the decided documentation, not a design draft.

(Written by Grok 4.7)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: a2bb2bd

No actionable issue found in this documentation-only change. doc/concept/standard.md:110-136 distinguishes the three intended relay behaviors and the older moq-lite handshake limitation, and its publisher-epoch/metadata links point to the corresponding sections. Recording these interoperability limits explicitly is the right direction; I am not treating the deliberate product deviations or the separately owned quest cleanup as missing implementation.

Verification: reviewed the full diff, surrounding standards and moq-lite documentation, and prior discussion. I did not rerun the documentation build, interop tests, or independently revalidate the external IETF section text. This is a draft COMMENT review, not merge approval.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5216e8b7-2277-4942-8e32-aad17c55354f
📥 Commits

Reviewing files that changed from the base of the PR and between 58711a3 and a2bb2bd.

📒 Files selected for processing (1)
  • doc/concept/standard.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging: docs only, CI green, and the OpenAI review of a2bb2bd9 has no findings. No open decisions. #5032 also edits doc/concept/standard.md and will reconcile on its side. The quest/m1/ietf-deviations-doc file lives on #5020, so delete it there (or right after it lands).

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 0f3e07d into main Oct 8, 2026
5 checks passed
@kixelated
kixelated deleted the quest/m1/ietf-deviations-doc branch October 8, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant