fix(net): finish the max_age to max_delay rename in tests

[kixelated]

Problem

main no longer compiles moq-net's tests. #4917 renamed the subscriber staleness bound to max_delay (SubscribeUpdate::max_delay, Subscription::with_max_delay), but two tests that landed alongside it still use the old name:

• rs/moq-net/src/lite/publisher.rs (two lite::SubscribeUpdate { max_age, .. } literals)
• rs/moq-net/tests/route_change.rs (Subscription::with_max_age)

Approach

Rename the three uses. No behavior change.

Impact

• None (tests only).

Alternatives

None; it is merge skew.

Follow-ups

None. Found while rebasing #4982.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[kixelated]

Grok review of d98eba0

This finishes the #4917 rename (SubscribeUpdate::max_age to max_delay, Subscription::with_max_age to with_max_delay) in the three test call sites that still used the old names. The diff matches the new definitions in rs/moq-net/src/lite/subscribe.rs:384 and rs/moq-net/src/model/subscription.rs:58,111.

I grepped every rs/ file at this head for leftovers and found none. Every remaining max_age / with_max_age is the publisher-side retention API (track::Info::max_age, moq_mux::catalog::Config, ts::Export, the SRT/RTMP/RTC builders), which #4917 kept on purpose. Nothing else should still fail to compile on the old subscriber names.

No issues found. CI was still queued when I looked, so confirm Check and Test pass, since compiling the tests is the whole point of this PR.

Verdict: MERGE once CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b5fb2e1a-df9f-4bc7-933f-6fc429778085

📥 Commits

Reviewing files that changed from the base of the PR and between 7b8d830 and d98eba0.

📒 Files selected for processing (2)

• rs/moq-net/src/lite/publisher.rs
• rs/moq-net/tests/route_change.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

---

Walkthrough

Two publisher update test fixtures now set max_delay instead of max_age. The redundant-publisher failover test also sets a 60-second maximum delay instead of a 60-second maximum age.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d98eb

The change updates stale test configuration names without an identified remaining merge risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the completion of the max_age to max_delay rename in tests, which matches the main change.
Description check	✅ Passed	The description explains the stale test references, the three renames, the compile issue, and the absence of behavior changes. It directly matches the changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kixelated]

Merge summary

• Renames the three stale max_age test uses left by feat!: name subscriber staleness max_delay; publisher retention keeps max_age #4917 merge skew to max_delay / with_max_delay. Tests only; no public API or wire impact.
• Reviews at d98eba00: CodeRabbit (no actionable comments) and Grok (no issues). Nothing to fix or reply to.
• Branch is current with main; no competing fix PR is open.
• Auto-merge enabled at d98eba00cbf3c55643205a8b383d73b1b851e10b, pending Check and Test.

(Written by Claude Opus 5.5)