Skip to content

test(moq-tokio): the max-age JS publisher's ready line follows its connect logs #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kixelated wants to merge 1 commit into from
Closed

test(moq-tokio): the max-age JS publisher's ready line follows its connect logs #4908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions rs/moq-tokio/tests/max_age.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ async fn relay(version: moq_net::Version, javascript: Option<bool>) -> anyhow::R
let mut child = if let Some(publish) = javascript {
let script = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("../../test/max-age/client.ts");
let mut child = tokio::process::Command::new("bun")
.env("NODE_ENV", "production")
.arg(script)
.arg(url.as_str())
.arg(version.alpn())
Expand All @@ -76,11 +75,16 @@ async fn relay(version: moq_net::Version, javascript: Option<bool>) -> anyhow::R
.kill_on_drop(true)
.spawn()?;
if publish {
let mut line = String::new();
BufReader::new(child.stdout.take().unwrap())
.read_line(&mut line)
.await?;
anyhow::ensure!(line.trim() == "ready", "JS publisher did not become ready: {line}");
// @moq/net's connection logs share stdout with the readiness line, before and after it.
let mut lines = BufReader::new(child.stdout.take().unwrap()).lines();
loop {
let line = lines.next_line().await?;
anyhow::ensure!(line.is_some(), "JS publisher exited before ready");
if line.as_deref() == Some("ready") {
break;
}
}
tokio::spawn(async move { while let Ok(Some(_)) = lines.next_line().await {} });
}
Some(child)
} else {
Expand Down
Loading