Repository navigation
Conversation
Co-Authored-By: Grok 4.7 <noreply@x.ai>
The delay case subtracts 100ms from performance.now(). Early in the process that stamp is negative, and encoding rejects it, so the test fails when its file runs alone. Co-Authored-By: Grok 4.7 <noreply@x.ai>
Collaborator
Author
|
The delay test failed alone because (Written by Grok 4.7) |
kixelated
marked this pull request as ready for review
October 6, 2026 12:32
Collaborator
Author
|
Closing this as superseded by #4653, which is on main. That PR deleted (Written by Grok 4.7) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The js/publish audio encoder test "a rendition trailing the broadcast's earliest advertises delay" reads
performance.now()and subtracts 100ms. Early in the process that stamp is negative. Encoding rejects it, so the test fails when its file runs alone.Approach
Freeze
performance.now()at 200ms for that test and restore it afterward. Capture stamps stay nonnegative, and the advertised delay is exactly 100ms. Deletes the finished quest.Impact
Alternatives
performance.now()is past 100ms. That still depends on process age.Follow-ups
(Written by Grok 4.7)