chore(quest): pin the flat-questline quest CLI

[kixelated]

Problem

kixelated/quest#44 dropped questline branches: questlines are now planning groups whose children PR straight to main. moq still pinned a quest CLI from before it, while quest/*README branches carry child work that is not on main.

Approach

• Bump the quest flake input to kixelated/quest 677f8d1 (main HEAD, includes Switch to webtransport-quinn #44, Webtransport generic #51, and A few minor changes to the API. #52). quest check passes on the tree unchanged.
• Add the .claude/skills/quest-iterate stub (quest skill iterate); skill: rename takeover to iterate kixelated/quest#52 renamed the CLI's takeover skill to iterate.
• CONTRIBUTING.md: the merge-commit rule names only release.
• quest/m1/quest-flat-lines.md: record the decisions and the remaining landings.

The line landings happen in each line's umbrella PR, not here.

Decisions (2026-10-04 /quest-plan interview, ✅ marks the choice)

• Goal confirm: ✅ Confirm / Also finish lines / Bump only.
• Landing default: Land partial now / Re-cut per child / Finish then land / ✅ (user) "merge main into the branch, mark PR as ready for review, then I'll do quest-complete later".
• Split: Per-line quests / One quest / Batch by size / ✅ (user) "spawn sub-agents to merge main for all of them, then mark as ready".
• Order: Bump last / Bump first / Bump first, sync quest files / ✅ (user) "the idea is to get rid of line branches", then confirmed ✅ Bump now.
• Empty lines: ✅ Close and retarget / Merge main and ready.
• Nested: ✅ Fold into parent / Retarget to main / Merge main, keep nesting.
• Takeover: Add stub, replace takeover / Add stub, keep both / Skip / ✅ (user) "add stub, replace takeover, rename it to quest-iterate".
• CONTRIBUTING: ✅ Yes, edit it / Leave it.

Impact

• No public API or wire changes.
• Agents get /quest-iterate; quest branch and quest ready --remote no longer exist.

Alternatives

• Bump after every line lands: keeps line branches alive, which is what this quest removes.

Follow-ups

• Land the umbrella PRs with /quest-complete: feat(audio): measure the auto playout target from arrival timing #4162, quest(wildcard): Wildcard advertisements #4403, quest(archive): Timeline-indexed MoQ archives #4034 (+quest(archive/track-timeline): Per-track timelines #4255), feat(net): in-band AUTH (questline) #4039, feat(cpp): the moq C++ package over moq-ffi, and the OBS plugin on it #4079, refactor(ffi)!: the bindings mirror Rust's layers #4519, quest(obs-moq-video): OBS native codecs #4080, quest(qos): Broadcast health and congestion #4133, refactor(net)!: plain u64 varint codec and simulated-time tests (rs2ts) #4437 (+quest(rs2ts): Sans-IO moq-net #4438), quest(test): make loaded test runs deterministic #4653, feat(tokio)!: upgrade a WebSocket fallback session to QUIC #4180, feat(test/ts): grade the full T-STD buffer model #4640.
• .github/workflows/quest.yml still triggers on quest/** pushes for "main merged into a questline"; drop that once the line branches are gone.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 04ffdaa1-9770-459d-98a9-efdb622dd8f5

📥 Commits

Reviewing files that changed from the base of the PR and between cc1079c and 21f5788.

⛔ Files ignored due to path filters (1)

• flake.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• .claude/skills/quest-iterate/SKILL.md
• CONTRIBUTING.md
• flake.nix
• quest/m1/quest-flat-lines.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

---

Walkthrough

The quest input now pins revision 677f8d11aa2fb71828ac7760bfa4bbf9d4165594. A new quest-iterate skill instructs users to run quest skill iterate or consult setup instructions if quest is not installed. CONTRIBUTING.md clarifies the merge-commit rule for PRs into release. The plan records flat questline decisions and related workflow changes.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 21f57

The pinned iteration instructions and flat-line branch guidance align with the checked-in setup and merge rules. No actionable merge blocker is established; the external landing command’s merge mode remains unverified.

Architecture Summary

Architecture risk: 🔵 Low · up to 21f57

The change affects 3 systems.

Changed systems: CONTRIBUTING.md, flake.nix, quest

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — CONTRIBUTING.md (service) was modified; 1 changed file maps to changed impact.
• observed — flake.nix (service) was modified; 1 changed file maps to changed impact.
• observed — quest (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in CONTRIBUTING.md: The guidance now specifically says PRs into release use a merge commit, replacing the rule that grouped release with other branches.
• observed — Modified behavior in flake.nix: The quest input URL now pins revision 677f8d11aa2fb71828ac7760bfa4bbf9d4165594 instead of 362489bcf02833d8674cff339463b086442cf92d.
• observed — Modified behavior in quest/m1/quest-flat-lines.md: The plan replaces the proposed CLI bump and maintainer-approved follow-up steps with a recorded pin at 677f8d1 and a report that quest check passed unchanged. It specifies flat questlines and the selected handling for code-carrying, code-free, and nested lines; records the skill replacement, CONTRIBUTING edit, and interview decisions; and lists the umbrella PRs still to land and branches to delete.
• observed — Modified behavior in .claude/skills/quest-iterate/SKILL.md: Adds the quest-iterate skill metadata and instructions to run quest skill iterate, with a setup link as the fallback when quest is not installed.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: pinning the flat-questline quest CLI.
Description check	✅ Passed	The description explains the CLI update and related skill, documentation, and follow-up changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kixelated]

Automated review of bcf91c92f0103bf511a561c8105879618ecfeb4b

This bumps the quest CLI pin to kixelated/quest 0cb952c, adds a quest-iterate skill stub, and updates CONTRIBUTING.md plus the quest doc. I checked the claims against the tree and the quest repo, and they hold up. 0cb952c is quest main HEAD and includes #44 (merged 2026-10-03) and #51. src/skills.rs still only registers takeover, so quest skill takeover in the stub is correct until kixelated/quest#52 (still open) lands. The stub matches the upstream quest-takeover stub word for word apart from its name. AGENTS.md has no questline wording left to update. Nothing else in the tree mentions quest branch or ready --remote outside this quest doc. The Quest check passes. I found no blocking issues.

Non-blocking

1. quest/m1/quest-flat-lines.md says the code-free lines "are closed and their branches deleted", but quest/m1/cluster-routing/README still exists on the remote, even though quest(relay): cluster routing with routes and upstream links #4654 is closed. The quic and broadcast-epoch branches are gone. Either delete that branch or describe it as pending.
2. The branch counts don't agree with each other. The doc says 16 line branches carried child work, and the PR body says 15 quest/*README branches carry child work. The remote has 15 branches today, and one of them is the code-free cluster-routing branch. The doc's own list has 14 code-carrying lines (12 umbrellas plus quest(archive/track-timeline): Per-track timelines #4255 and quest(rs2ts): Sans-IO moq-net #4438) and 3 code-free ones. This only affects the paper trail, but it's worth fixing so the "Done when" check is easy to verify later.
3. All 12 umbrella PRs listed under "Remaining" are still drafts, and quest(archive/track-timeline): Per-track timelines #4255 and quest(rs2ts): Sans-IO moq-net #4438 are still open against their parent branches. That's consistent with this PR saying the landings happen elsewhere. Just note that the decision to "merge main and mark ready" hasn't been carried out yet, so these won't show up as ready-for-review yet.
4. .github/workflows/quest.yml still triggers on quest/** pushes, and its header comment still mentions "main merged into a questline". The follow-up already covers this. It's harmless until the branches are gone, and it actually helps validate the main merges into the line branches in the meantime.
5. CI is still pending apart from Quest. The flake bump changes the pinned quest build, so wait for Check to go green before merging.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

[kixelated]

Automated review by review (OpenAI)
Reviewed commit: bcf91c9

Direction: the focused CLI pin bump and separate umbrella-PR landings are reasonable; no public API or wire changes. The flake and lock revisions agree, and the pinned CLI does register takeover.

One integration gap: .claude/skills/quest-iterate/SKILL.md:2 installs only /quest-iterate, but the pinned assets/skills/complete.md:14,23 still offers and dispatches /quest-takeover. There is no repository stub under that name. Calling quest skill takeover inside the new stub handles direct /quest-iterate use, but does not update /quest-complete's advertised action. Please align those references when landing the rename, or explicitly map that action to /quest-iterate for this transitional pin.

The existing review already covers branch-cleanup/count discrepancies; no duplicate inline comments added.

Verification limits: static diff and pinned upstream-source inspection only; I did not build the Nix package, run quest check, or execute the interactive skill flow. CI was still running when checked. No other actionable correctness issues found.

(Written by OpenAI)

[kixelated]

Automated re-review of afd575402040c0fbb336dbd7f7455f5e84e9ba7e (after the push from bcf91c92)

This push re-pins quest to 677f8d1 and points the quest-iterate stub at quest skill iterate. I checked it against upstream. 677f8d1 is the merge commit of kixelated/quest#52 (merged 2026-10-04 21:29 PT) and is quest main HEAD. Its src/skills.rs registers iterate, and the new stub matches upstream's .claude/skills/quest-iterate/SKILL.md word for word. Nothing under .claude/skills/ still references takeover. I found no blocking issues.

Earlier findings

• Fixed: the branch counts. The doc no longer gives a number, and the cluster-routing branch is listed by name.
• Fixed: CONTRIBUTING.md now names only release.
• Still open, and outside this PR: the 12 umbrella PRs are still drafts, and quest(archive/track-timeline): Per-track timelines #4255 and quest(rs2ts): Sans-IO moq-net #4438 haven't been folded in yet.
• Still open, and tracked as a follow-up: the quest/** trigger and the "main merged into a questline" comment in .github/workflows/quest.yml.

Non-blocking

1. The new "Remaining" item in quest/m1/quest-flat-lines.md says to delete quest/m1/cluster-routing/README, but that branch is already gone (the API returns 404). 14 quest/*README branches are left, all on lines with code. Drop the item or mark it done. Small wording nit: "Code-free lines ... close and their branches are deleted" reads awkwardly now that it's in the present tense.
2. The PR body is stale. It still says the stub runs quest skill takeover until A few minor changes to the API. #52 lands, and it lists "bump the pin again after A few minor changes to the API. #52" as a follow-up. Since the squash merge uses the body as the commit message, update it before merging.
3. CI is all pending, Quest included. The pinned quest build changed again, so wait for Check and Quest to go green.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

[kixelated]

Automated follow-up review of 21f578854cf3aa067216c9f97f4e9f45ac03eb32 (re-review after push from bcf91c92)

The push re-pins quest to kixelated/quest 677f8d1 and points the quest-iterate stub at quest skill iterate. I checked this against upstream. 677f8d1 is quest main HEAD, it's the merge of kixelated/quest#52, and src/skills.rs there registers iterate with no takeover entry left. The stub now matches upstream's .claude/skills/quest-iterate/SKILL.md byte for byte, description included. The doc drops the "once #52 merges" follow-up, which is now done. No blocking issues.

Earlier findings

1. Fixed. quest/m1/cluster-routing/README is gone from the remote, so the doc's claim that code-free line branches were deleted now holds.
2. Fixed. The "16 questline branches" count is gone. The remote now has 14 quest/**/README branches, which matches the doc's 12 umbrellas plus the nested quest(archive/track-timeline): Per-track timelines #4255 and quest(rs2ts): Sans-IO moq-net #4438.
3. Still open, but it's moving. Some umbrellas (feat(audio): measure the auto playout target from arrival timing #4162, refactor(ffi)!: the bindings mirror Rust's layers #4519) have been marked ready, and the rest still have to be landed through /quest-complete as the doc says.
4. Still open, as a tracked follow-up. .github/workflows/quest.yml still triggers on quest/**.
5. Still open. Every check, Quest included, is queued again on the new head. The flake bump rebuilds the pinned quest, so wait for Quest and Check to go green before merging.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

[kixelated]

Automated review by review (OpenAI)
Reviewed commit: 21f5788

No new actionable findings in the two-commit delta since bcf91c9. The previous integration finding is fixed: .claude/skills/quest-iterate/SKILL.md:6 now calls quest skill iterate, and the new upstream pin registers iterate and uses /quest-iterate in both complete and spawn. flake.nix:30 and flake.lock:73,79 agree on 677f8d11aa2fb71828ac7760bfa4bbf9d4165594.

Direction remains sound: synchronize the CLI and skill rename here, keep the umbrella landings separately scoped. This is a meaningful integration fix, not just a rebase; no public API or wire changes.

Verification limits: static PR-delta and pinned upstream-source review only. No Nix build, quest check, or interactive-flow execution performed; the latest head's Check, WASM, OBS, and X11 capture runs were queued. This comment is not merge approval.

(Written by OpenAI)

[kixelated]

Enabling auto-merge on 21f578854cf3aa067216c9f97f4e9f45ac03eb32; the maintainer picked /quest-merge for this PR.

• Re-pinned quest to 677f8d1, the merge of skill: rename takeover to iterate kixelated/quest#52, so the quest-iterate stub runs quest skill iterate and the pinned complete and spawn skills offer /quest-iterate. This resolves the OpenAI review's integration finding.
• CONTRIBUTING.md line 4 now reads "PRs into release use a merge commit".
• Addressed the Grok review: the branch count is gone, and the leftover quest/m1/cluster-routing/README branch is deleted (no open PR targeted it or came from it).
• Both reviews of the final head have no new findings. The umbrella landings and the quest.yml quest/** trigger remain follow-ups, as listed in the description.

(Written by Claude Opus 5.5)

[kixelated]

Re-enabling auto-merge on 21f578854cf3aa067216c9f97f4e9f45ac03eb32; the maintainer picked /quest-merge again.

• The earlier auto-merge was turned off 26s after it was enabled, recorded as "Manually disabled by user". No head change, ruleset, or required check refused it.
• Head is unchanged since the last reviews, both of which had no new findings. No open review threads.
• Since then main only touched files outside this diff (its quest/m1 changes are to sibling quests), and GitHub reports it mergeable with all checks green.

(Written by Claude Opus 5.5)