Repository navigation
quest: address review of the imported-issue replan #4802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # [M] moq adopts flat questlines from the current quest CLI | ||
|
|
||
| ## Goal | ||
|
|
||
| moq pins a quest release where questlines are planning groups with no branch | ||
| of their own: every quest, including a questline README's remaining work, is | ||
| its own PR against `main`. The child work already merged into questline | ||
| branches reaches `main`, and those branches retire. | ||
|
|
||
| ## Plan | ||
|
|
||
| kixelated/quest#44 dropped questline branches, `quest branch`, and | ||
| `quest ready --remote`; kixelated/quest#51 changed the import skill to treat a | ||
| report's fix as a claim and plan each issue fully. moq still pins the quest | ||
| input in `flake.nix` from before both. | ||
|
|
||
| Decided (2026-10-04): a quest of its own, not a routine pin bump, because 16 | ||
| questline branches carry merged child work that is not on `main` | ||
| (`git ls-remote origin 'refs/heads/quest/*README'`). | ||
|
|
||
| - Bump the `quest` input and run `quest check` with the new CLI; fix what it | ||
| reports. | ||
| - For each questline branch, land its accumulated work on `main` through its | ||
| existing umbrella PR, or a new one, then delete the branch. A branch whose | ||
| work cannot land yet is decided with the maintainer, not left orphaned. | ||
| - Add the `quest-takeover` skill stub beside the other `.claude/skills/quest-*` | ||
| stubs, and decide with the maintainer whether it replaces the existing | ||
| `takeover` skill. | ||
| - Update `AGENTS.md` and `CONTRIBUTING.md` only where they describe questline | ||
| branches, with the maintainer's approval, as both files require. | ||
|
|
||
| Done when `flake.nix` pins the new quest, no `quest/*README` branch remains, | ||
| and `quest check` passes. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Merge queue](/quest/m1/merge-queue.md) - the other trunk workflow change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Use the previous group's start, not its maximum PTS
HANG explicitly permits frames below the previous group's content, provided they do not precede its start (group rules). The existing overlap regression accepts group 0 at 0/33/66 ms followed by group 1 at 50/83 ms. The new maximum-based rule rejects the valid 50 ms keyframe and terminates that recording. Align the plan with the producer/consumer's existing previous-group-start floor, and retain this cross-group overlap case alongside the reset and within-group B-frame cases.