Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The export's linger starts when the broadcast end reaches it, which can precede the publisher process exiting. Timing from that exit let load eat the 900ms lower bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
October 3, 2026 15:57
Collaborator
Author
|
Merging into
(Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
a_clean_finish_exits_zero_once_the_linger_expires(rs/moq-cli/tests/export.rs) failed its>= 900mslower bound in CI on #4725. It started the timer after the publisher process exited, but the export's 1s linger starts when the broadcast end reaches it, which can come first. Under load that gap ate the bound.Approach
Take the instant before
drop(stdin). The broadcast can only end after stdin closes, so the linger can't start sooner and the bound stays correct. Subprocess test, so a paused clock can't apply.The siblings (
a_drop_exits_one_once_the_linger_expires,a_publisher_restarted_within_the_linger_resumes_the_output) assert no elapsed time, so they don't share the race.Scoped as
quest/m1/test-flakes-2/export-linger.md([XS]) in the first commit and deleted on completion in the second, matching #4715 and #4722. Net diff is the test fix.Decisions
drop(stdin).Impact
Validation
just check: passed.quest check: ok.cargo nextest run --stress-count 20of the test alongside 40yesCPU hogs on 32 cores and a loopingcargo nextest run -p moq-net: 20/20 passed.Follow-ups
None.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)