Repository navigation
deps: bump moq-noq stack to 2.0.1 - #4699
Conversation
Picks up RUSTSEC-2026-0185 (assembler chunk cap) and raw QUIC sessions sending RESET_STREAM/STOP_SENDING codes as-is (moq-dev/noq#27). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MERGE — clean patch bump of the moq-noq stack on Workspace pins ( Non-blocking
This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: 799b87090309ac328aba2a1bff2e686a235af827
No actionable bug found in this dependency bump. The direction is sound for dev: all three workspace minimums require 2.0.1, the four updated registry packages are published and not yanked, and their checksums match Cargo.lock. The dependency MSRV remains below this workspace's floor. Only four package versions change; the inspected socket2/windows-sys edge changes satisfy their registry constraints.
I checked the upstream reassembly-cap and raw-stream-code changes against the adapter consumers. The existing review's mixed-version warning remains important: legacy mapped codes are accepted by the new adapter, but older raw peers do not interpret its new codes correctly. That limitation is explicitly recorded in #4614; this is not a compatibility-neutral rollout. Leaving the iroh and receive-window follow-ups open is appropriate.
Verification: static manifest/lockfile, registry metadata, upstream patch, and consumer inspection. No build or tests run here; the author's local test results were not independently reproduced, and CI was still pending.
|
Merging: CI green on (Written by Claude Opus 5.5) |
Bumps
web-transport-moq,moq-noq,moq-noq-proto, andmoq-noq-udpfrom 2.0.0 to 2.0.1 ondev.moqt://,moql://) send RESET_STREAM and STOP_SENDING codes as-is instead of HTTP/3-mapped, and still decode an older peer's mapped codes.Only these four packages change version in
Cargo.lock. The other lock edits re-point existing edges (moq-noq-udp2.0.1 moves tosocket20.6, already locked, and somewindows-sysedges settle on 0.60); no packages are added or removed.qmux is unchanged: 0.6.1 is the newest 0.6.x and predates moq-dev/web-transport#406, so that fix waits for a qmux 0.6.2.
Impact
devin fix: raw QUIC stream codes stay raw #4614. A fixed peer reads older peers' mapped codes; an older moq peer reads a fixed peer's codes as a transport error (stream-scoped on moq-lite).Quests
quest/m1/raw-stream-codes.mdstays open: fix: raw QUIC stream codes stay raw #4614 finishes it onceweb-transport-iroh0.8.x with fix: send raw QUIC stream codes as is in iroh and quinn web-transport#408 is released.quest/m0/noq-reassembly-cap.mdstays open onmain(fix(moq-tokio): finite default connection receive window (noq reassembly cap, part 1) #4605):main's pin, the receive-window default, and upstream irohnoq-protoremain.Tests
just checkandjust test interop --allpass.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)