-
-
Notifications
You must be signed in to change notification settings - Fork 250
chore(quest): turn outside conditions into quests and bump quest #4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
01c6a4d
f34a67e
2838fa1
dd95bb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| name: quest-finish | ||
| name: quest-complete | ||
| description: Decide which open PRs to merge, then merge them in parallel. | ||
| --- | ||
|
|
||
| Run `quest skill finish` and follow its output. | ||
| Run `quest skill complete` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: quest-export | ||
| description: Turn active quests into GitHub issues before leaving Quest. Use when the user invokes /quest-export or asks to export quests before removing Quest. | ||
| --- | ||
|
|
||
| Run `quest skill export` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: quest-import | ||
| description: Import GitHub issues as quests. | ||
| --- | ||
|
|
||
| Run `quest skill import` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # [S] Merge main into dev | ||
|
|
||
| ## Goal | ||
|
|
||
| `dev` contains `main` at or after | ||
| [#4506](https://github.com/moq-dev/moq/pull/4506) (`c2e7b5815`), so dev has | ||
| the `ts::stats` module the TS stats rename works on. | ||
|
|
||
| ## Plan | ||
|
|
||
| Unlike the other outside conditions, this is work: a PR merging `main` into | ||
| `dev` and resolving its conflicts. As of 2026-09-30 `main` is 130 commits | ||
| ahead of `dev` and `dev` is 119 ahead of `main`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # [XS] A self-hosted NVIDIA runner is registered | ||
|
|
||
| ## Goal | ||
|
|
||
| A self-hosted GitHub Actions runner is registered for moq-dev/moq on the | ||
| maintainer's Linux host (RTX 3070 Ti), with the NVIDIA driver installed. This | ||
| is a maintainer action: only someone with admin access to the repository and | ||
| the host can do it. | ||
|
|
||
| This quest tracks a condition outside the repository. When it holds, delete | ||
| this quest and every `Required` entry that links it. | ||
|
|
||
| ## Plan | ||
|
|
||
| As of 2026-09-30 `gh api repos/moq-dev/moq/actions/runners` lists none. | ||
| Register it with the dedicated label and hardening that | ||
| [GPU CI](/quest/m1/gpu-ci.md) describes, and share the registration with the | ||
| io_uring runner the drain line plans. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # [XS] A week of nightly interop after #4529 | ||
|
|
||
| ## Goal | ||
|
|
||
| Seven nightly interop runs on `main` have completed since | ||
| [#4529](https://github.com/moq-dev/moq/pull/4529) added the player's `delay` | ||
| column to the interop trace. | ||
|
|
||
| This quest tracks a condition outside the repository. When it holds, delete | ||
| this quest and every `Required` entry that links it. | ||
|
|
||
| ## Plan | ||
|
|
||
| #4529 merged on 2026-09-29 (`8b6abc0a1`). As of 2026-09-30 one scheduled | ||
| `interop.yml` run on `main` includes it, so the seventh lands around | ||
| 2026-10-06. Check with `gh run list --workflow interop.yml --branch main`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # [XS] dev's decoded-frame surface reaches main | ||
|
|
||
| ## Goal | ||
|
|
||
| `main` contains the moq-ffi decoded-frame surface from `dev` | ||
| ([#4094](https://github.com/moq-dev/moq/pull/4094), renamed in `97575f002`). | ||
|
|
||
| This quest tracks a condition outside the repository. When it holds, delete | ||
| this quest and every `Required` entry that links it. | ||
|
Comment on lines
+8
to
+9
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P2] Keep this condition visible through the remote questline overlay With the current remote branches, this new condition still disappears from normal (Written by OpenAI Codex)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 2838fa1: moved to (Written by Claude Opus 5.5) |
||
|
|
||
| ## Plan | ||
|
|
||
| As of 2026-09-30 both are on `dev` only. Check with | ||
| `git merge-base --is-ancestor 97575f002 origin/main`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '1,25p' quest/m1/obs-decoded-surface.md
sed -n '1,8p' CONTRIBUTING.md
git show --no-patch --format=fuller 97575f002 2>&1 | head -20Repository: moq-dev/moq Length of output: 1296 🏁 Script executed: set -eu
printf '%s\n' '--- changed files ---'
git diff --name-status 72adc66a293370c2e1b2146d5c3fcc124611b9b8 dd95bb4a6076efa09adc24dfb45c3d070029e38e
printf '%s\n' '--- decoded-frame references ---'
rg -n -i 'decoded[- ]frame|decoded.*surface|moq-ffi|97575f002|obs-decoded-surface' --glob '!*.lock' .
printf '%s\n' '--- quest file and linked Required entries ---'
cat -n quest/m1/obs-decoded-surface.md
rg -n -C 3 'obs-decoded-surface' questRepository: moq-dev/moq Length of output: 41149 Use a content-level check for the decoded-frame surface.
🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # [XS] web-transport-moq 1.3.3 ships noq#24 | ||
|
|
||
| ## Goal | ||
|
|
||
| A `web-transport-moq` 1.3.x release on crates.io carries | ||
| [moq-dev/noq#24](https://github.com/moq-dev/noq/pull/24), the close-capsule | ||
| fix. | ||
|
|
||
| This quest tracks a condition outside the repository. When it holds, delete | ||
| this quest and every `Required` entry that links it. | ||
|
|
||
| ## Plan | ||
|
|
||
| noq#24 merged into `release/1.3` on 2026-09-29. As of 2026-09-30 crates.io | ||
| still has 1.3.2; the release PR is | ||
| [moq-dev/noq#21](https://github.com/moq-dev/noq/pull/21). |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,7 +21,7 @@ Implement in the fork. | |||||
| - On loss detection, before queueing a retransmission for a stream with a | ||||||
| deadline, estimate the arrival instant as now plus the forward one-way | ||||||
| delay. Start with `min_rtt / 2`, corrected by the peer's reported ACK delay; | ||||||
| the [receive-timestamps spike](/quest/m3/quic-receive-ts.md) replaces that | ||||||
| the [GCC experiment](/quest/m3/quic-gcc.md)'s receive timestamps replace that | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: set -eu
printf '%s\n' '--- changed file at head ---'
git show --format= --no-ext-diff 01c6a4d8e10be813cd23a71214f8d291d0675845:quest/m2/quic-deadline.md | nl -ba | sed -n '1,90p'
printf '%s\n' '--- PR diff for changed file ---'
git diff --no-ext-diff d29985af7fdb10e66b98120ac295bc90b1913b45 01c6a4d8e10be813cd23a71214f8d291d0675845 -- quest/m2/quic-deadline.md
printf '%s\n' '--- related references ---'
rg -n -i --glob '*.md' 'receive.?timestamp|forward delay|min_rtt|clock.?offset|one.?way|absolute' quest/m2 quest/m3 2>/dev/null | head -160Repository: moq-dev/moq Length of output: 7615 🤖 get_repo_knowledge executed:
Length of output: 47338 🏁 Script executed: set -eu
printf '%s\n' '--- GCC experiment ---'
git show --format= --no-ext-diff 01c6a4d8e10be813cd23a71214f8d291d0675845:quest/m3/quic-gcc.md | nl -ba | sed -n '1,100p'
printf '%s\n' '--- receive-timestamps spike, if present ---'
if git cat-file -e 01c6a4d8e10be813cd23a71214f8d291d0675845:quest/m3/quic-receive-ts.md 2>/dev/null; then
git show --format= --no-ext-diff 01c6a4d8e10be813cd23a71214f8d291d0675845:quest/m3/quic-receive-ts.md | nl -ba | sed -n '1,100p'
else
printf '%s\n' 'not present at reviewed head'
fi
printf '%s\n' '--- all timestamp/offset terminology in referenced plans ---'
rg -n -i --glob '*.md' 'clock.?offset|offset|synchron|timestamp|one.?way|forward delay|inter.?arrival|half.?RTT' quest/m3/quic-gcc.md quest/m3/quic-receive-ts.md quest/m2/quic-deadline.md 2>/dev/null || trueRepository: moq-dev/moq Length of output: 5050 🌐 Web query:
💡 Result: Define the absolute-delay estimator.
Specify the clock-offset or equivalent estimator. Otherwise, describe the timestamps as an adjustment to the Suggested wording- the [GCC experiment](/quest/m3/quic-gcc.md)'s receive timestamps replace that
- guess with a measured forward delay. If the estimate is past the deadline,
+ the [GCC experiment](/quest/m3/quic-gcc.md)'s receive timestamps adjust that
+ guess with measured forward-delay variation. If the estimate is past the
+ deadline,
...
-- [QUIC GCC](/quest/m3/quic-gcc.md) - its receive timestamps give a measured
- forward delay that replaces the half-RTT estimate
+- [QUIC GCC](/quest/m3/quic-gcc.md) - its receive timestamps adjust the
+ half-RTT estimate with measured forward-delay variation📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair point, but the "measured forward delay" claim predates this PR (it pointed at the old receive-ts spike); this PR only retargets the link. Leaving the estimator design to whoever picks up (Written by Claude Opus 5.5)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Would you like me to open a follow-up issue for the estimator design? You are interacting with an AI system. |
||||||
| guess with a measured forward delay. If the estimate is past the deadline, | ||||||
| reset the stream with a dedicated error code and drop its retransmit ranges, | ||||||
| including bytes already lost, so flow control is returned in one step. | ||||||
|
|
@@ -52,8 +52,8 @@ Decided in the 2026-09-30 audit: moved to m2. No m1 quest consumes it. | |||||
|
|
||||||
| ## Related | ||||||
|
|
||||||
| - [Receive timestamps](/quest/m3/quic-receive-ts.md) - a measured forward | ||||||
| delay replaces the half-RTT estimate | ||||||
| - [QUIC GCC](/quest/m3/quic-gcc.md) - its receive timestamps give a measured | ||||||
| forward delay that replaces the half-RTT estimate | ||||||
| - [Discover media headroom](/quest/m2/quic-probe.md) - can reuse | ||||||
| retransmission machinery if redundant capacity probes prove worthwhile | ||||||
| - [noq#813](https://github.com/n0-computer/noq/issues/813) - the per-stream deadline proposal to n0 | ||||||
Uh oh!
There was an error while loading. Please reload this page.