-
-
Notifications
You must be signed in to change notification settings - Fork 249
quest(m1): split cluster routing into child quests #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
55769d9
quest(m1): split cluster routing into child quests
kixelated 0c771c8
quest(m1): address review on cluster routing split
kixelated 98e02c5
quest(m1): propagation waits on the memory benchmark
kixelated b0393d5
quest(m1): align selection refusals with wildcard, gate later children
kixelated c841d45
quest(m1): boundary re-origination, IETF cluster peers, refusal tier
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # [S] Cluster idle timeout | ||
|
|
||
| ## Goal | ||
|
|
||
| A relay notices a silent peer relay within seconds, not after the 30 s QUIC | ||
| idle timeout it shares with every viewer. moq.pro's routing simulator found | ||
| that failure detection, not routing, sets every outage window: a silent link | ||
| or relay loss goes unnoticed for the idle timeout in every routing design, | ||
| and subscribes through it go nowhere meanwhile. | ||
|
|
||
| ## Plan | ||
|
|
||
| - Cluster sessions get their own idle timeout and keep-alive, shorter than | ||
| the `--quic-*` defaults (`rs/moq-tokio/src/quic.rs`, 30 s idle and 5 s | ||
| keep-alive). A keep-alive alone only keeps a quiet session open; the | ||
| timeout is what detects loss. | ||
| - QUIC's effective idle timeout is the smaller of the two endpoints' | ||
| (RFC 9000 section 10.1), so the dialing relay's setting bounds both sides of | ||
| a cluster link. Say so where the setting is documented. | ||
| - Pick the default in the PR with its reasoning: loss detection against | ||
| spurious drops on a lossy intercontinental link. | ||
| - Docs: `doc/bin/relay/cluster.md` and `doc/bin/relay/config.md`. | ||
|
|
||
| Public API: adds a relay config field; lands on `main`. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Cluster routing](/quest/m1/cluster-routing/README.md) - its liveness and failover depend on this detection | ||
| - [Broadcast epochs](/quest/m1/broadcast-epoch/README.md) - viewers wait out the same timeout for an old route | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a configured
https://cluster peer falls back to WebSocket, this QUIC-only plan does not shorten failure detection:rs/moq-tokio/src/websocket.rs:351-355constructs the fallback with the fixedKeepAlive::default()5 s/30 s policy. Such links therefore retain the outage window this quest is intended to remove. Include the WebSocket transport in the configurable cluster-session timeout, or explicitly refuse it for cluster links when the shorter policy cannot be applied. (Written by GPT-5.6 Sol)AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.