-
-
Notifications
You must be signed in to change notification settings - Fork 249
quest: address the 2026-09-30 audit review #4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ camera, MediaProjection for the screen, and MediaCodec for encode and decode. | |
|
|
||
| ## Plan | ||
|
|
||
| MediaCodec encode/decode already exist in moq-video. Reuse them rather than | ||
| Rust owns capture and codecs on mobile, settled in the 2026-09-30 audit ([Mobile ownership](/quest/m1/mobile-ownership.md)). MediaCodec encode/decode already exist in moq-video. Reuse them rather than | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After this line settles Rust ownership and removes the ownership prerequisite, the unchanged paragraph below still says the Rust path does not benefit the mobile SDK and that this concern decides whether the XL quest is worth doing. This also conflicts with AGENTS.md reference: AGENTS.md:L28-L28 Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed the cost paragraph is stale against the verdict (it also says raw frames cannot cross FFI zero-copy, while mobile-ownership bridges HardwareBuffer/Surface as opaque handles). Whether the XL Rust Android capture replaces moq-kit's Kotlin capture, or stays gated on a Rust-native consumer, is a scope call for the maintainer, so this PR is held for that decision rather than merged. (Written by Claude Opus 5.5) |
||
| planning a second backend family. The remaining capture and native Surface | ||
| integration needs NDK/JNI lifecycle, synchronization, and actual device proof. | ||
|
|
||
|
|
@@ -21,10 +21,6 @@ decides whether XL is worth spending. | |
| `moq-tokio` already reaches into Android through JNI for `tls::init_android`, | ||
| so the mechanism exists. | ||
|
|
||
| ## Required | ||
|
|
||
| - [Ownership boundary](/quest/m1/mobile-ownership.md) - decides whether an NDK/JNI backend family is worth building | ||
|
|
||
| ## Related | ||
|
|
||
| - [iOS capture](/quest/m2/mobile-capture-ios.md) - the other half of mobile, which | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,15 +9,13 @@ work and deferred mobile phases are complete before #700 closes. | |
| ## Plan | ||
|
|
||
| This quest owns the cross-phase completion proof, not another implementation. | ||
| Use the chosen Rust or platform-owned capture path and the existing binding | ||
| APIs. Record the supported path, limitations, and reproducible device results; | ||
| wire repeatable coverage into CI and identify the hardware evidence separately. | ||
| Update the native/mobile getting-started docs with the working path. | ||
|
|
||
| The ownership decision may replace the Rust capture quests with platform-owned | ||
| work. In that case, update this quest's Required links to the replacement | ||
| implementation and proof quests before removing the abandoned blockers. | ||
| Abandoning a backend is not evidence that native/mobile support is complete. | ||
| Use the Rust capture path and the existing binding APIs: Rust owns capture | ||
| and codecs on mobile, settled in the 2026-09-30 audit | ||
| ([Mobile ownership](/quest/m1/mobile-ownership.md)). Record the supported | ||
|
Comment on lines
+12
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Once ownership is settled here, AGENTS.md reference: AGENTS.md:L28-L28 Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, fixed in 918c6e7: the m2 index entries for iOS and Android capture no longer read as conditional on the ownership decision. (Written by Claude Opus 5.5) |
||
| path, limitations, and reproducible device results; wire repeatable coverage | ||
| into CI and identify the hardware evidence separately. Update the | ||
| native/mobile getting-started docs with the working path. | ||
|
|
||
| Do not close #700 merely because its next subset or a design decision finished. | ||
|
|
||
| ## Required | ||
|
|
@@ -26,7 +24,6 @@ Do not close #700 merely because its next subset or a design decision finished. | |
| - [Dart codec parity](/quest/m1/dart-codecs.md) - codec-enabled artifacts and Dart video consumer integration | ||
| - [iOS capture](/quest/m2/mobile-capture-ios.md) - deliver the selected iOS capture path | ||
| - [Android capture](/quest/m2/mobile-capture-android.md) - deliver the selected Android capture and codec path | ||
| - [Mobile ownership](/quest/m1/mobile-ownership.md) - select and scope the mobile media architecture | ||
|
|
||
| ## Closes | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.