quest(m1/auth): move peer grants to the P2P line - #4590
Conversation
Peer grants have one consumer, P2P signaling, so they move to quest/m2/p2p/peer-grant.md and leave the auth line's Required. The auth README now scopes the no-prefix-only AUTH_OK rule to lite (IETF AUTH_OK carries prefixes and answers NOT_SUPPORTED otherwise) and adopts relay-refresh's connection-owned Connection::auth() handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE (head Quest-only follow-up to #4589: moves Claims checked
CI: Check + Test green. Non-blocking
This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8ad7606
No actionable bugs found in the four-file diff.
Direction: keep this focused correction. Moving peer grants to their sole P2P consumer removes an unnecessary auth-line dependency; waiting for the complete auth line preserves landing order without introducing a dependency cycle. The IETF subtree-only AUTH_OK wording matches the existing codec and draft, and the connection-owned handle matches relay-refresh's reconnect contract. No extra abstraction is needed.
Verification: inspected all changed files, the auth/P2P prerequisites, rs/moq-net/src/ietf/auth.rs and the auth draft; checked changed local links against the exact head tree. Public API/wire/runtime changes: none. I did not run quest check or just check; quest, just and Nix are unavailable here.
(Written by OpenAI)
|
Merging: quest-only follow-up to #4589. Peer grants move to (Written by Claude Opus 5.5) |
Follow-up to the 2026-09-30 audit (#4589) for the auth line.
quest/m1/auth/peer-grant.mdtoquest/m2/p2p/peer-grant.md. P2P signaling is its only consumer, so it becomes a P2P child ranked beforesignal.md(which already required it) and leaves the auth line's Required. It now requires the auth README instead ofrelay-refresh.md, since relay tokens only reachmainwhen the line lands.drafts/draft-lcurley-moq-auth.mdPrefixes,rs/moq-net/src/ietf/auth.rsencode_prefixes).Connection::auth()is the connection-owned handle thatrelay-refresh.mddescribes, replacing "the live session's auth handle".Public API / wire: none (quest files only).
Decisions
Connection handle wording (README vs relay-refresh.md)
auth::HandleSequencing with #4589
maininto the line, then this PR against the linePeer grants placement (decided by the maintainer before planning): move to
quest/m2/p2p/peer-grant.md, required byp2p/signal.md, out of the auth line.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code