Skip to content

quest(m1): drop the retired TS import shared shift - #4583

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/drop-ts-import-shared-shift
Sep 30, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/drop-ts-import-shared-shift

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

quest/m1/ts-import-shared-shift.md still exists on main, but the mechanism it plans is already gone. #4543 removed the Reanchor shift on dev and made a rewind end the import instead, so there is no shift left to share. Its own body said #4513 was obsolete.

Approach

Delete the quest and its three references:

  • quest/m1/README.md (the milestone child list)
  • quest/m1/hop-aligned-import.md (a Related link)
  • quest/m1/remove-live.md (a Related link)

Per the quest guide, a quest that can no longer be completed is abandoned by deleting it and removing every reference.

Impact

  • Public API: none.
  • Wire: none.
  • No code change. quest check passes at 448 documents.

Follow-ups

(Written by Space Bunny Free)

#4543 removed the Reanchor shift on dev and made a rewind end the import
instead, so there is no shift left to share. The quest and its three
references describe a mechanism the code no longer has.

Closes #4513

Co-Authored-By: Space Bunny Free <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c584ec18-46e8-4aca-9814-19b47c97fa86

📥 Commits

Reviewing files that changed from the base of the PR and between 146769e and 5c8c69e.

📒 Files selected for processing (2)
  • quest/m1/README.md
  • quest/m1/ts-import-shared-shift.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T14:29:01.480803Z 5c8c69e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging: dev already deleted this quest in 798ce05 (every importer refuses a timestamp rewind), so it is only removed from main here. Approved in a quest audit session; #4589 absorbs it afterwards.

(Written by Claude Opus 5.5)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: ecf239e

No actionable findings in the four-file diff. Deleting the retired quest and its three incoming links is the right, minimal direction: #4543 has merged to dev and actually removed both Reanchor and this quest. Keeping a replacement shift plan on main would contradict that decision; the broadcast-epoch follow-up remains linked from the surviving quests.

Verification: read the complete deletion, both neighboring quest plans, repository instructions and the pinned quest guide; checked the three indexed references and #4543's relevant diff/merge state. The head's Check workflow succeeded. I did not run quest check locally because quest/Nix are unavailable here, and I did not rerun TS behavior tests. Documentation-only change; no public API or wire impact.

(Written by OpenAI)

# Conflicts:
#	quest/m1/hop-aligned-import.md
#	quest/m1/remove-live.md
#	quest/m1/ts-import-shared-shift.md
@kixelated
kixelated merged commit cead1bd into main Sep 30, 2026
3 checks passed
@kixelated
kixelated deleted the quest/m1/drop-ts-import-shared-shift branch September 30, 2026 14:27
@kixelated

Copy link
Copy Markdown
Collaborator Author

Review (MERGE)

Reviewed head 5c8c69e65c6112667926b2336c4204f86d736acc (now landed on main as cead1bd306e9).

Docs/quest cleanup only: deletes the retired ts-import-shared-shift plan and its m1 README entry after #4543 removed Reanchor on dev and closed #4513 as obsolete. Correct abandon per the quest guide; head has no remaining path or Related links to the deleted file (the hop-aligned / remove-live cleanups were already on main via #4589).

Blocking

None.

Non-blocking

  1. PR body is slightly stale after the main merge. It still claims this PR edits quest/m1/hop-aligned-import.md and quest/m1/remove-live.md. After merging main, the effective diff is only quest/m1/README.md (−1) and deleting quest/m1/ts-import-shared-shift.md. Harmless now that it has merged; worth remembering when stacking quest-audit PRs.

CI Check/Test were green on the reviewed head.

Verdict: MERGE

This is an automated review, not the maintainer's decision
(Written by Grok)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant