chore(quest): fix the WebTransport close capsule upstream - #4497
Conversation
…OSE_LINGER Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Recommendation: MERGEPositive improvement: Yes. #4429's 10s Worth the complexity: Yes. Diff is +39 docs only (quest + README link). No public API or wire change. Complexity of the eventual work is modest and already scoped; the quest itself is cheap to keep. Different approach? Folding into Notes (non-blocking):
MERGE this quest as written. This is an automated review, not the maintainer's decision |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e7f455ce4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| moq-tokio. #4429 has no end-to-end test, so add a moq-tokio regression | ||
| where a refused `https://` session reports its code to the client and | ||
| fails on the 1.3.2 pin without the linger. |
There was a problem hiding this comment.
Test the browser failure instead of duplicating the Rust test
This scenario cannot provide the promised red/green signal: before #4429, rs/moq-tokio/tests/broadcast.rs::session_close_surfaces_a_rejection_code already ran a rejected https:// session with web-transport-moq 1.3.2 and no linger, then asserted that the client received Unauthorized. Because the reported failure is Chromium-specific, another Rust-peer test with the same assertion will pass before the upstream fix; exercise a browser or equally strict HTTP/3 peer, or specify an alternate setup that actually reproduces the failure, before using the test to justify deleting the workaround.
AGENTS.md reference: AGENTS.md:L16-L18
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed, fixed in a836d6a. The regression now lives in web-transport-moq and asserts that the capsule is read before the H3 control stream ends, since a Rust peer passes either way.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary: adds (Written by Claude Opus 5.5) |
Adds
quest/m1/wt-close-upstream.md[S]. It fixes web-transport-moq'sSession::closeupstream so the CLOSE_WEBTRANSPORT_SESSION capsule is delivered without the caller keeping the session alive, then deletes the 10sCLOSE_LINGERworkaround that #4429 added to moq-tokio. The quest is ranked next to the other close-code quests inquest/m1/README.md.It also records the other decisions from this planning session. Those land in their own PRs.
Decisions
#4320 (release-plz, regenerated at 06:52 into a real release PR): what should happen to it?
#4429's close-code fix is a 10s linger around an upstream bug. How should this be tracked?
Where do the varint_interop 2^62 / 2^64-1 cases go?
Delete the merged local
worktree-agent-*branches withgit branch -d?#4467: when a cluster route's first hop changes, what happens to subscriptions already served from the old publisher?
#4369: when should JS page-load
Livefire?#4463: plain
u64or restore theVarIntnewtype?Public API: none. Wire: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code