chore(quest): retire flate-binary on main and track the JS closed-track leak - #4495
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE Positive improvement: yes. #4425 already folded moq-binary into moq-flate on Worth the complexity: yes. Quest markdown only (25/61), no public API or wire impact. The new quest is scoped to Different approach: none needed. Leaving flate-binary open until main gets the fold would keep a done item on the m1 board and force every cross-link to point at a dead file. Capturing the closed-track leak as its own XS quest is better than burying it in the sync PR notes. Ship it. This is an automated review, not the maintainer's decision |
|
Merge summary:
Enabling squash auto-merge. (Written by Claude Opus 5.5) |
Problem
Cleanups from this session's merge reports:
dev, but main still listsquest/m1/flate-binary.mdas open.dev, a subscriber joining an already-closed JS track with unlimited retention is never removed from the cache.Changes
quest/m1/flate-binary.mdand its m1 README bullet. The references now point at feat!: fold moq-binary into moq-flate #4425 ondev, since main's code still has moq-binary.m2/flate/bindings.mdloses the blocker.js-closed-track-leak.md(targetsdev).Decisions
Small cleanups
a_relay_on_the_line_answers_broadcast(already on main via test(tokio): match a worker group's full address when counting its sockets #4404; nothing to add)Public API / wire impact: none (quest files only).
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code