Conversation
…ant pattern Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4277 specified that a malformed or non-canonical grant pattern is a PROTOCOL_VIOLATION (
drafts/draft-lcurley-moq-lite.md, Path Pattern), but Rust and JS only drop the token and keep the session up. Maintainer decisions from the 09-28 merged-PR audit: both implementations close the session with PROTOCOL_VIOLATION to match the draft (fail loud), with tests in both languages, before the line lands onmain. The maintainer also decided that an out-of-rangeExpiresin AUTH_OK closes the session the same way.Approach
New child quest Malformed grant on the auth line (finding, decline). Verified still present on the line branch: Rust's
PresentTokenends only the token on the decode error, and the JS#runloop inauth_session.tscatches it the same way.The quest covers:
Expiresdoes the same (decided here). Rust already labels it a ProtocolViolation but only ends the token. The draft does not yet define "out of range", so the quest adds that definition to it.Expires).Impact
Alternatives
Follow-ups
(Written by Opus 5.5)
🤖 Generated with Claude Code