Skip to content

quest(moxygen): block the line on the #4276 group fetch fill findings - #4376

Merged
kixelated merged 7 commits into
quest/m1/moxygen/READMEfrom
audit/moxygen-blockers
Sep 29, 2026
Merged

kixelated merged 7 commits into
quest/m1/moxygen/READMEfrom
audit/moxygen-blockers

Conversation

@kixelated

@kixelated kixelated commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

#4276 merged into this line with three Codex P2 findings unanswered. Maintainer decisions from the 09-28 merged-PR audit: each blocks the line from landing on main.

Approach

New child quest Group fetch fill on the moxygen line, covering:

  • A truncated fetch stream is cached as a complete group, since FETCH_OK's end_location is never checked (r4113942736). For a whole-group request, where end_location is only the requested boundary, the quest requires a concrete complete-group signal.
  • A first fetch object with no IDs is accepted by the (false, None | Some(1)) arm (r4113942737).
  • The upstream group FETCH asks from object 0, ignoring the request's frame_start (r4113942733).

All three verified still present on the line branch.

The README also records the three declines the maintainer accepted, so they are not reopened: mid-group FETCH start (r4113671550), FETCH_OK naming the requested end (r4114050992), and the ignored contradictory End of Track (r4114051032).

No blocker for the #4273 priority default: quest/m1/signed-priority.md on main already covers it.

Impact

  • Quest files only. No API or wire change.

Alternatives

  • One quest per finding. Rejected: all three touch the same fill path in ietf/subscriber.rs and would conflict.

Follow-ups

  • None beyond the new quest.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 29, 2026 13:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T19:21:32.072868Z 1cee2e1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Verdict: MERGE

Positive improvement and well-scoped for a line-blocking quest. The three #4276 findings are concrete, still present on the line, and grouped correctly (same ietf/subscriber.rs fill path) rather than split into conflicting child quests.

  • Truncation vs FETCH_OK.end_location, anonymous first-object acceptance, and ignoring frame_start on the upstream FETCH are each named with a file/behavior fix and a regression test expectation.
  • Maintainer-accepted declines (mid-group FETCH start, FETCH_OK naming the requested end, contradictory End of Track) are recorded so they are not reopened — good hygiene.
  • Complexity is justified: quest docs only, no premature API/wire change.

Worth landing so the moxygen line cannot ship the incomplete fill.

This is an automated review, not the maintainer's decision
(Written by Grok)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c36fb8dbdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/moxygen/fetch-fill.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c36fb8dbdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/moxygen/fetch-fill.md Outdated
kixelated and others added 2 commits September 29, 2026 11:23
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1297cb3b60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/moxygen/fetch-fill.md Outdated
Comment thread quest/m1/moxygen/fetch-fill.md Outdated
…ect field

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3649817e6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/moxygen/fetch-fill.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb1bccc2f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/moxygen/README.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated merged commit ff1ed07 into quest/m1/moxygen/README Sep 29, 2026
5 of 7 checks passed
@kixelated
kixelated deleted the audit/moxygen-blockers branch September 29, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant