docs: fix stale agent rules, the moq-net hop range, and the ffi unannounce doc - #4305
Conversation
…ounce doc - rs/AGENTS.md: internal dev-dependencies are path-only (#4015), and tests crossing real networking run on the wall clock (#4244, #4291). - rs/moq-net/AGENTS.md: point at fuzz/fuzz_targets/ instead of a stale list. - moq-net CHANGELOG: random hops stay below 2^53 (#3933), not 62-bit. - moq-ffi: unannounce on a standalone broadcast is a no-op. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. WalkthroughThe changes update Rust workspace dependency and async testing guidance, revise fuzzing instructions, and clarify the Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The documentation and regenerated checksum changes introduce no actionable merge risk based on the complete diff. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
An audit of the PRs merged since 09-24 found docs that no longer match the code:
rs/AGENTS.mdsays crates use{ workspace = true }for every dependency. Since fix(rs): make internal dev-dependencies path-only so releases publish #4015, internal dev-dependencies must be path-only, or releases fail to publish._publish-testenforces this.rs/AGENTS.mdsays every time-dependent async test pauses tokio time. test(relay): run the outage lease test on the real clock #4244 and test(auth): run the outage grant test on the real clock #4291 moved socket-backed outage tests to the real clock, because a paused clock can't drive real I/O.rs/moq-net/AGENTS.mdlists fuzz targets that are out of date. It is missingpatternandannounce.Hop::random).MoqBroadcastProducer::unannouncesays it errors withClosedon a standalone broadcast. It actually returnsOkand does nothing.Approach
Correct each line to match the code. The two
rs/AGENTS.mdrules were approved by the maintainer during the audit.Validation
Regenerated the Dart bindings (
moq.dart), since they carry the doc comment.just checkpasses apart frommoq-clia_frame_read_times_out, a known load-only flake that the new test-flakes quest tracks.Impact
(Written by Opus 5.5)
🤖 Generated with Claude Code