Skip to content

test(auth): run the outage grant test on the real clock #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Sep 26, 2026
Merged

test(auth): run the outage grant test on the real clock #4291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions rs/moq-auth/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,30 +514,43 @@ mod tests {
assert_eq!(reason, Reason::Expired);
}

/// On the real clock: a paused one jumps to the expiry timer whenever the runtime
/// waits on a socket, and macOS delivers loopback asynchronously, so the lease can
/// expire and drop the re-check before the server sees it. Load only delays the
/// close, so asserting it never lands before `expires` holds on a busy machine.
#[tokio::test]
async fn an_outage_keeps_the_grant_until_expires() {
tokio::time::pause();
// Whole seconds, as the grant crosses the wire, so the client sees this exact instant.
let now = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap();
let expires = SystemTime::UNIX_EPOCH + Duration::from_secs(now.as_secs() + 3);
Comment on lines +524 to +525

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the expiry test on Tokio's paused clock

This makes an explicitly time-dependent test wait 2 to 3 real seconds and depend on the adjustable system clock. Every run now slows the suite, a backward clock adjustment can fail the post-close comparison, and a setup stall beyond the expiry plus five-second skew makes connect(...).unwrap() fail before the behavior is tested. Please remove the socket/virtual-clock coupling at its source, such as by isolating the driver's HTTP transport, rather than moving this test to wall-clock time; the scoped testing convention requires time-dependent async tests to pause Tokio time.

AGENTS.md reference: rs/AGENTS.md:L51-L54

Useful? React with 馃憤聽/ 馃憥.


let log = Log::default();
let client = clock_server(
log.clone(),
grant(Some(Duration::from_secs(3)), Some(Duration::from_secs(1))),
false,
)
let server = server(log.clone(), move |request| match request.event {
Event::Connect => {
let mut grant = grant(None, Some(Duration::from_secs(1)));
grant.expires = Some(expires);
ResponseTemplate::new(200).set_body_json(grant)
}
Event::Revalidate => ResponseTemplate::new(503),
Event::End { .. } => ResponseTemplate::new(200),
})
.await;
let consumer = client.connect(request()).await.unwrap();
let consumer = client(&server).connect(request()).await.unwrap();

tokio::time::sleep(Duration::from_millis(1500)).await;
assert!(log.revalidates() >= 1, "re-checks happened");
let reason = tokio::time::timeout(Duration::from_secs(10), consumer.closed())
.await
.expect("expired");
assert_eq!(reason, Reason::Expired);
assert!(SystemTime::now() >= expires, "an outage must not close before expires");
assert!(
log.revalidates() >= 1,
"no re-check reached the server during the outage"
);
assert_eq!(
consumer.grant().publish,
patterns(&["**"]),
"the grant stands through the outage"
);

let reason = tokio::time::timeout(Duration::from_secs(5), consumer.closed())
.await
.expect("expired");
assert_eq!(reason, Reason::Expired);
assert!(matches!(
log.end().await.event,
Event::End {
Expand Down
Loading