-
-
Notifications
You must be signed in to change notification settings - Fork 249
feat(net): spread a prefix's pool across paths, stitch on the reply's origin #4279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3002322
quest(wildcard): claim spread
kixelated 56cf789
feat(net): spread a prefix's pool across paths, stitch on the reply's…
kixelated 04902d7
feat(net): name the serving origin in SUBSCRIBE_OK and FETCH_OK
kixelated c513a57
feat(net): proxy the reply origin in JS, and name a random one when n…
kixelated f03345e
fix(net): name the origin before a subscription's first datagram
kixelated 35da5ff
feat(net): spread equal-cost routes in @moq/net too
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If two replies for one consumed broadcast name different origins, this assignment silently replaces the first identity after its content may already have been delivered. A JavaScript application republishing that broadcast can then label existing origin A content as origin B, allowing a downstream relay to admit or splice it under the wrong identity. Treat a second distinct name as a protocol failure, matching the Rust provenance/front checks, rather than accepting malformed peer state.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not taking this one. A second distinct name for one consumed broadcast is not malformed: the upstream relay's front ends on an origin mismatch, and a later request for the same announced broadcast can land on a new front serving another origin. Throwing there would tear down a healthy session. The real gap is granularity (JS records the origin per broadcast, not per track), which only matters for a JS app republishing a broadcast across an upstream failover; a downstream Rust relay still refuses to splice across a mismatch. Listed under Known gaps in the description for the maintainer to decide on.
(Written by Claude Opus 5.5)